bug #37167 [Mime] use fromString when creating a new Address (fabpot)

fabpot · fabpot · commit 5b719d1ee408 · 2020-06-09T17:06:27.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Mime] use fromString when creating a new Address | Q | A | ------------- | --- | Branch? | 4.4  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | n/a  | License | MIT | Doc PR | n/a When creating an Address, there are two ways right now in 4.4: `Address::create()` which takes an email or an instance of Address and `Address::fromString()` which takes an email or an email+name. In 4.4, I propose to make `create` supports everything possible. And in 5.2, I will probably propose to deprecate `fromString()`. Commits ------- de68787 [Mime] use fromString when creating a new Adress
diff --git a/src/Symfony/Component/Mime/Address.php b/src/Symfony/Component/Mime/Address.php
@@ -89,7 +89,7 @@ public static function create($address): self
             return $address;
         }
         if (\is_string($address)) {
-            return new self($address);
+            return self::fromString($address);
         }
 
         throw new InvalidArgumentException(sprintf('An address can be an instance of Address or a string ("%s") given).', \is_object($address) ? \get_class($address) : \gettype($address)));

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public static function create($address): self`
`89`	`89`	`return $address;`
`90`	`90`	`}`
`91`	`91`	`if (\is_string($address)) {`
`92`		`- return new self($address);`
	`92`	`+ return self::fromString($address);`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`throw new InvalidArgumentException(sprintf('An address can be an instance of Address or a string ("%s") given).', \is_object($address) ? \get_class($address) : \gettype($address)));`