[ObjectMapper] allow owning ObjectMapper object

soyuka · soyuka · commit 52c92a2017f9 · 2025-07-17T12:07:30.000+02:00
diff --git a/src/Symfony/Component/ObjectMapper/ObjectMapper.php b/src/Symfony/Component/ObjectMapper/ObjectMapper.php
@@ -40,7 +40,11 @@ public function __construct(
         private readonly ?PropertyAccessorInterface $propertyAccessor = null,
         private readonly ?ContainerInterface $transformCallableLocator = null,
         private readonly ?ContainerInterface $conditionCallableLocator = null,
+        private ?ObjectMapperInterface $objectMapper = null,
     ) {
+        if (!$objectMapper) {
+            $objectMapper = $this;
+        }
     }
 
     public function map(object $source, object|string|null $target = null): object
@@ -203,7 +207,7 @@ private function getSourceValue(object $source, object $target, mixed $value, \S
             } elseif ($objectMap->contains($value)) {
                 $value = $objectMap[$value];
             } else {
-                $value = $this->map($value, $mapTo->target);
+                $value = $this->objectMapper->map($value, $mapTo->target);
             }
         }
 
@@ -319,4 +323,9 @@ private function getSourceReflectionClass(object $source, \ReflectionClass $targ
 
         return $targetRefl;
     }
+
+    public function setObjectMapper(ObjectMapperInterface $objectMapper): void
+    {
+        $this->objectMapper = $objectMapper;
+    }
 }
diff --git a/src/Symfony/Component/ObjectMapper/ObjectMapperAwareInterface.php b/src/Symfony/Component/ObjectMapper/ObjectMapperAwareInterface.php
@@ -0,0 +1,26 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\ObjectMapper;
+
+/**
+ * @experimental
+ *
+ * @author Antoine Bluchet <soyuka@gmail.com>
+ */
+interface ObjectMapperAwareInterface
+{
+    /**
+     * Sets the owning ObjectMapper object.
+     */
+    public function setObjectMapper(ObjectMapperInterface $objectMapper): void;
+}
+
diff --git a/src/Symfony/Component/ObjectMapper/Tests/ObjectMapperTest.php b/src/Symfony/Component/ObjectMapper/Tests/ObjectMapperTest.php
@@ -20,6 +20,7 @@
 use Symfony\Component\ObjectMapper\Metadata\ObjectMapperMetadataFactoryInterface;
 use Symfony\Component\ObjectMapper\Metadata\ReflectionObjectMapperMetadataFactory;
 use Symfony\Component\ObjectMapper\ObjectMapper;
+use Symfony\Component\ObjectMapper\ObjectMapperInterface;
 use Symfony\Component\ObjectMapper\Tests\Fixtures\A;
 use Symfony\Component\ObjectMapper\Tests\Fixtures\B;
 use Symfony\Component\ObjectMapper\Tests\Fixtures\C;
@@ -345,4 +346,45 @@ public function testDefaultValueStdClassWithPropertyInfo()
         $this->assertSame('abc', $b->id);
         $this->assertNull($b->optional);
     }
+
+    public function testDecorateObjectMapper(): void
+    {
+        $mapper = new ObjectMapper();
+        $myMapper = new class($mapper) implements ObjectMapperInterface {
+            private ?\SplObjectStorage $embededMap = null;
+
+            public function __construct(private readonly ObjectMapperInterface $mapper)
+            {
+                $this->embededMap = new \SplObjectStorage();
+            }
+
+            public function map(object $source, object|string|null $target = null): object
+            {
+                if (isset($this->embededMap[$source])) {
+                    $target = $this->embededMap[$source];
+                }
+
+                $mapped = $this->mapper->map($source, $target);
+                $this->embededMap[$source] = $mapped;
+                return $mapped;
+            }
+        };
+
+        $mapper->setObjectMapper($myMapper);
+
+        $d = new D(baz: 'foo', bat: 'bar');
+        $c = new C(foo: 'foo', bar: 'bar');
+        $myNewD = $myMapper->map($c);
+
+        $a = new A();
+        $a->foo = 'test';
+        $a->transform = 'test';
+        $a->baz = 'me';
+        $a->notinb = 'test';
+        $a->relation = $c;
+        $a->relationNotMapped = $d;
+
+        $b = $mapper->map($a);
+        $this->assertSame($myNewD, $b->relation);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,11 @@ public function __construct(`
`40`	`40`	`private readonly ?PropertyAccessorInterface $propertyAccessor = null,`
`41`	`41`	`private readonly ?ContainerInterface $transformCallableLocator = null,`
`42`	`42`	`private readonly ?ContainerInterface $conditionCallableLocator = null,`
	`43`	`+ private ?ObjectMapperInterface $objectMapper = null,`
`43`	`44`	`) {`
	`45`	`+ if (!$objectMapper) {`
	`46`	`+ $objectMapper = $this;`
	`47`	`+ }`
`44`	`48`	`}`
`45`	`49`
`46`	`50`	`public function map(object $source, object\|string\|null $target = null): object`
`@@ -203,7 +207,7 @@ private function getSourceValue(object $source, object $target, mixed $value, \S`
`203`	`207`	`} elseif ($objectMap->contains($value)) {`
`204`	`208`	`$value = $objectMap[$value];`
`205`	`209`	`} else {`
`206`		`- $value = $this->map($value, $mapTo->target);`
	`210`	`+ $value = $this->objectMapper->map($value, $mapTo->target);`
`207`	`211`	`}`
`208`	`212`	`}`
`209`	`213`
`@@ -319,4 +323,9 @@ private function getSourceReflectionClass(object $source, \ReflectionClass $targ`
`319`	`323`
`320`	`324`	`return $targetRefl;`
`321`	`325`	`}`
	`326`	`+`
	`327`	`+ public function setObjectMapper(ObjectMapperInterface $objectMapper): void`
	`328`	`+ {`
	`329`	`+ $this->objectMapper = $objectMapper;`
	`330`	`+ }`
`322`	`331`	`}`