Added more tests for the new feature

javiereguiluz · javiereguiluz · commit 52c42e79a5e2 · 2018-06-22T13:13:05.000+02:00
diff --git a/src/Symfony/Component/Translation/Tests/Command/XliffLintCommandTest.php b/src/Symfony/Component/Translation/Tests/Command/XliffLintCommandTest.php
@@ -40,6 +40,23 @@ public function testLintCorrectFile()
         $this->assertContains('OK', trim($tester->getDisplay()));
     }
 
+    /**
+     * @dataProvider provideStrictFilenames
+     */
+    public function testStrictFilenames($requireStrictFileNames, $fileNamePattern, $targetLanguage, $mustFail)
+    {
+        $tester = $this->createCommandTester($requireStrictFileNames);
+        $filename = $this->createFile('note', $targetLanguage, $fileNamePattern);
+
+        $tester->execute(
+            array('filename' => $filename),
+            array('verbosity' => OutputInterface::VERBOSITY_VERBOSE, 'decorated' => false)
+        );
+
+        $this->assertEquals($mustFail ? 1 : 0, $tester->getStatusCode());
+        $this->assertContains($mustFail ? '[WARNING] 0 XLIFF files have valid syntax and 1 contain errors.' : '[OK] All 1 XLIFF files contain valid syntax.', $tester->getDisplay());
+    }
+
     public function testLintIncorrectXmlSyntax()
     {
         $tester = $this->createCommandTester();
@@ -102,7 +119,7 @@ public function testGetHelp()
     /**
      * @return string Path to the new file
      */
-    private function createFile($sourceContent = 'note', $targetLanguage = 'en')
+    private function createFile($sourceContent = 'note', $targetLanguage = 'en', $fileNamePattern = 'messages.%locale%.xlf')
     {
         $xliffContent = <<<XLIFF
 <?xml version="1.0"?>
@@ -118,7 +135,7 @@ private function createFile($sourceContent = 'note', $targetLanguage = 'en')
 </xliff>
 XLIFF;
 
-        $filename = sprintf('%s/translation-xliff-lint-test/messages.en.xlf', sys_get_temp_dir());
+        $filename = sprintf('%s/translation-xliff-lint-test/%s', sys_get_temp_dir(), str_replace('%locale%', 'en', $fileNamePattern));
         file_put_contents($filename, $xliffContent);
 
         $this->files[] = $filename;
@@ -129,11 +146,11 @@ private function createFile($sourceContent = 'note', $targetLanguage = 'en')
     /**
      * @return CommandTester
      */
-    private function createCommandTester($application = null)
+    private function createCommandTester($requireStrictFileNames = true, $application = null)
     {
         if (!$application) {
             $application = new Application();
-            $application->add(new XliffLintCommand());
+            $application->add(new XliffLintCommand(null, null, null, $requireStrictFileNames));
         }
 
         $command = $application->find('lint:xliff');
@@ -160,4 +177,16 @@ protected function tearDown()
         }
         rmdir(sys_get_temp_dir().'/translation-xliff-lint-test');
     }
+
+    public function provideStrictFilenames()
+    {
+        yield array(false, 'messages.%locale%.xlf', 'en', false);
+        yield array(false, 'messages.%locale%.xlf', 'es', true);
+        yield array(false, '%locale%.messages.xlf', 'en', false);
+        yield array(false, '%locale%.messages.xlf', 'es', true);
+        yield array(true, 'messages.%locale%.xlf', 'en', false);
+        yield array(true, 'messages.%locale%.xlf', 'es', true);
+        yield array(true, '%locale%.messages.xlf', 'en', true);
+        yield array(true, '%locale%.messages.xlf', 'es', true);
+    }
 }
