feature #14288 [Console] Add getters for Application::$autoExit and $catchExceptions (VasekPurchart)

fabpot · fabpot · commit 4f26a2e6e529 · 2016-01-27T12:22:59.000+01:00
This PR was submitted for the 2.7 branch but it was merged into the 3.1-dev branch instead (closes #14288). Discussion ---------- [Console] Add getters for Application::$autoExit and $catchExceptions There is currently no way to retrieve this information from Application (afaik) and since this can be set from outside (and is even part of the `@api`) it should be retrievable. This might come handy for example when working with an Application instance inside your code - for example when creating a Console exception listener - then you need information about how the application was run. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 5d191d3 [Console] Add getters for Application:: and
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -239,6 +239,16 @@ public function getHelp()
         return $this->getLongVersion();
     }
 
+    /**
+     * Gets whether to catch exceptions or not during commands execution.
+     *
+     * @return bool Whether to catch exceptions or not during commands execution
+     */
+    public function areExceptionsCaught()
+    {
+        return $this->catchExceptions;
+    }
+
     /**
      * Sets whether to catch exceptions or not during commands execution.
      *
@@ -249,6 +259,16 @@ public function setCatchExceptions($boolean)
         $this->catchExceptions = (bool) $boolean;
     }
 
+    /**
+     * Gets whether to automatically exit after a command execution or not.
+     *
+     * @return bool Whether to automatically exit after a command execution or not
+     */
+    public function isAutoExitEnabled()
+    {
+        return $this->autoExit;
+    }
+
     /**
      * Sets whether to automatically exit after a command execution or not.
      *
diff --git a/src/Symfony/Component/Console/Tests/ApplicationTest.php b/src/Symfony/Component/Console/Tests/ApplicationTest.php
@@ -484,6 +484,7 @@ public function testSetCatchExceptions()
         $tester = new ApplicationTester($application);
 
         $application->setCatchExceptions(true);
+        $this->assertTrue($application->areExceptionsCaught());
         $tester->run(array('command' => 'foo'), array('decorated' => false));
         $this->assertStringEqualsFile(self::$fixturesPath.'/application_renderexception1.txt', $tester->getDisplay(true), '->setCatchExceptions() sets the catch exception flag');
 
@@ -497,6 +498,15 @@ public function testSetCatchExceptions()
         }
     }
 
+    public function testAutoExitSetting()
+    {
+        $application = new Application();
+        $this->assertTrue($application->isAutoExitEnabled());
+
+        $application->setAutoExit(false);
+        $this->assertFalse($application->isAutoExitEnabled());
+    }
+
     public function testRenderException()
     {
         $application = $this->getMock('Symfony\Component\Console\Application', array('getTerminalWidth'));
