Feedback about BC layer

chadyred · chadyred · commit 4ca59ff1dcd9 · 2025-01-27T12:00:14.000+01:00
diff --git a/UPGRADE-7.3.md b/UPGRADE-7.3.md
@@ -113,4 +113,4 @@ VarDumper
 AssetMapper
 -----------
 
- * Deprecated passing null to `ImportMapRequireCommand` constructor argument `projectDir`
+ * Deprecate passing null to `ImportMapRequireCommand` constructor argument `projectDir`
diff --git a/src/Symfony/Component/AssetMapper/CHANGELOG.md b/src/Symfony/Component/AssetMapper/CHANGELOG.md
@@ -6,7 +6,7 @@ CHANGELOG
 
  * Add support for pre-compressing assets with Brotli, Zstandard, Zopfli, and gzip
  * Add option `--dry-run` to `importmap:require` command
- * Deprecated passing null to `ImportMapRequireCommand` constructor argument `projectDir`
+ * Deprecate passing null to `ImportMapRequireCommand` constructor argument `projectDir`
 
 7.2
 ---
diff --git a/src/Symfony/Component/AssetMapper/Command/ImportMapRequireCommand.php b/src/Symfony/Component/AssetMapper/Command/ImportMapRequireCommand.php
@@ -149,9 +149,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 array_map(fn (ImportMapEntry $package): array => [
                     $package->importName,
                     $package->version ?? '-',
-                    // BC layer for FrameworkBundle < 7.3
-                    // When projectDir is not set, we use the absolute path of the package
-                    isset($this->projectDir) ? Path::makeRelative($package->path, $this->projectDir) : $package->path,
+                    // BC layer for AssetMapper < 7.3
+                    // When `projectDir` is not null, we use the absolute path of the package
+                    null !== $this->projectDir ? Path::makeRelative($package->path, $this->projectDir) : $package->path,
                 ], $newPackages),
             );
         }
