bug #62503 [HttpClient] Fix releasing uploaded stream resources (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 48ddde4e6033 · 2025-11-27T15:26:44.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] Fix releasing uploaded stream resources | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #60506 | License | MIT The recursive closure kept $streams (and therefore the original resources) reachable until the GC cycle collector ran, so multipart uploads held file handles even after the request lifecyle ended. Setting $caster = null breaks the cycle immediately, letting the resources be released right after the request. Commits ------- 9fc5ab8 [HttpClient] Fix releasing uploaded stream resources
diff --git a/src/Symfony/Component/HttpClient/HttpClientTrait.php b/src/Symfony/Component/HttpClient/HttpClientTrait.php
@@ -355,6 +355,7 @@ private static function normalizeBody($body, array &$normalizedHeaders = [])
                     }
                 }
             });
+            $caster = null;
 
             if ('' === $body = http_build_query($body, '', '&')) {
                 return '';

Original file line number	Diff line number	Diff line change
`@@ -355,6 +355,7 @@ private static function normalizeBody($body, array &$normalizedHeaders = [])`
`355`	`355`	`}`
`356`	`356`	`}`
`357`	`357`	`});`
	`358`	`+ $caster = null;`
`358`	`359`
`359`	`360`	`if ('' === $body = http_build_query($body, '', '&')) {`
`360`	`361`	`return '';`