feature #43280 [HttpClient] Add method to set response factory in mock client (greeflas)

nicolas-grekas · nicolas-grekas · commit 3e387cfdecfb · 2021-10-05T09:51:47.000+02:00
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [HttpClient] Add method to set response factory in mock client | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no  | Tickets | Fix #40620  | License | MIT | Doc PR | symfony/symfony-docs#15883   Commits ------- 2e028cc [HttpClient] Add method to set response factory in mock client
diff --git a/src/Symfony/Component/HttpClient/CHANGELOG.md b/src/Symfony/Component/HttpClient/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+5.4
+---
+
+ * Add `MockHttpClient::setResponseFactory()` method to be able to set response factory after client creating
+
 5.3
 ---
 
diff --git a/src/Symfony/Component/HttpClient/MockHttpClient.php b/src/Symfony/Component/HttpClient/MockHttpClient.php
@@ -35,6 +35,15 @@ class MockHttpClient implements HttpClientInterface
      * @param callable|callable[]|ResponseInterface|ResponseInterface[]|iterable|null $responseFactory
      */
     public function __construct($responseFactory = null, ?string $baseUri = 'https://example.com')
+    {
+        $this->setResponseFactory($responseFactory);
+        $this->defaultOptions['base_uri'] = $baseUri;
+    }
+
+    /**
+     * @param callable|callable[]|ResponseInterface|ResponseInterface[]|iterable|null $responseFactory
+     */
+    public function setResponseFactory($responseFactory): void
     {
         if ($responseFactory instanceof ResponseInterface) {
             $responseFactory = [$responseFactory];
@@ -47,7 +56,6 @@ public function __construct($responseFactory = null, ?string $baseUri = 'https:/
         }
 
         $this->responseFactory = $responseFactory;
-        $this->defaultOptions['base_uri'] = $baseUri;
     }
 
     /**
diff --git a/src/Symfony/Component/HttpClient/Tests/MockHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/MockHttpClientTest.php
@@ -291,6 +291,7 @@ protected function getHttpClient(string $testCase): HttpClientInterface
             case 'testReentrantBufferCallback':
             case 'testThrowingBufferCallback':
             case 'testInfoOnCanceledResponse':
+            case 'testChangeResponseFactory':
                 $responses[] = new MockResponse($body, ['response_headers' => $headers]);
                 break;
 
@@ -387,4 +388,16 @@ public function testHttp2PushVulcainWithUnusedResponse()
     {
         $this->markTestSkipped('MockHttpClient doesn\'t support HTTP/2 PUSH.');
     }
+
+    public function testChangeResponseFactory()
+    {
+        /* @var MockHttpClient $client */
+        $client = $this->getHttpClient(__METHOD__);
+        $expectedBody = '{"foo": "bar"}';
+        $client->setResponseFactory(new MockResponse($expectedBody));
+
+        $response = $client->request('GET', 'http://localhost:8057');
+
+        $this->assertSame($expectedBody, $response->getContent());
+    }
 }
