minor #62250 [Messenger] Fix unreachable catch (SerheyDolgushev)

nicolas-grekas · nicolas-grekas · commit 3dbadfe391dd · 2025-10-31T16:20:27.000+01:00
This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Messenger] Fix unreachable catch | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | n/a | License | MIT Fix for `PhanUnreachableCatch` [phan issues](https://github.com/phan/phan): ``` Catch statement for \Doctrine\DBAL\Exception\TableNotFoundException is unreachable. An earlier catch statement at line 168 caught the ancestor class/interface \Doctrine\DBAL\Driver\Exception ``` Commits ------- affca58 [Messenger] Fix unreachable catch
diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
@@ -166,12 +166,12 @@ public function get(): ?array
         if ($this->driverConnection->getDatabasePlatform() instanceof MySQLPlatform) {
             try {
                 $this->driverConnection->delete($this->configuration['table_name'], ['delivered_at' => '9999-12-31 23:59:59']);
-            } catch (DriverException $e) {
-                // Ignore the exception
             } catch (TableNotFoundException $e) {
                 if ($this->autoSetup) {
                     $this->setup();
                 }
+            } catch (DriverException $e) {
+                // Ignore the exception
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -166,12 +166,12 @@ public function get(): ?array`
`166`	`166`	`if ($this->driverConnection->getDatabasePlatform() instanceof MySQLPlatform) {`
`167`	`167`	`try {`
`168`	`168`	`$this->driverConnection->delete($this->configuration['table_name'], ['delivered_at' => '9999-12-31 23:59:59']);`
`169`		`- } catch (DriverException $e) {`
`170`		`- // Ignore the exception`
`171`	`169`	`} catch (TableNotFoundException $e) {`
`172`	`170`	`if ($this->autoSetup) {`
`173`	`171`	`$this->setup();`
`174`	`172`	`}`
	`173`	`+ } catch (DriverException $e) {`
	`174`	`+ // Ignore the exception`
`175`	`175`	`}`
`176`	`176`	`}`
`177`	`177`