silence PHP warnings issued by Redis::connect()

xabbuh · xabbuh · commit 38fd27e1ce47 · 2024-11-12T23:11:06.000+01:00
diff --git a/src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
@@ -121,7 +121,20 @@ private static function initializeRedis(\Redis $redis, string $host, int $port,
             return $redis;
         }
 
-        $redis->connect($host, $port);
+        @$redis->connect($host, $port);
+
+        set_error_handler(function ($type, $msg) use (&$error) { $error = $msg; });
+
+        try {
+            $isConnected = $redis->isConnected();
+        } finally {
+            restore_error_handler();
+        }
+
+        if (!$isConnected) {
+            throw new InvalidArgumentException(sprintf('Redis connection failed: %s', preg_match('/^Redis::p?connect\(\): (.*)/', $error ?? $redis->getLastError() ?? '', $matches) ? \sprintf(' (%s)', $matches[1]) : ''));
+        }
+
         $redis->setOption(\Redis::OPT_SERIALIZER, $serializer);
 
         if (null !== $auth && !$redis->auth($auth)) {
