[TypeInfo] Fix handling ConstFetchNode

norkunas · norkunas · commit 38d6ac62d8db · 2025-06-18T14:20:51.000+03:00
diff --git a/src/Symfony/Component/TypeInfo/Tests/Fixtures/DummyWithConstants.php b/src/Symfony/Component/TypeInfo/Tests/Fixtures/DummyWithConstants.php
@@ -0,0 +1,19 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\TypeInfo\Tests\Fixtures;
+
+final class DummyWithConstants
+{
+    public const DUMMY_A = 'a';
+    public const DUMMY_B = 'b';
+    public const DUMMY_C = 'c';
+}
diff --git a/src/Symfony/Component/TypeInfo/Tests/TypeResolver/StringTypeResolverTest.php b/src/Symfony/Component/TypeInfo/Tests/TypeResolver/StringTypeResolverTest.php
@@ -19,6 +19,7 @@
 use Symfony\Component\TypeInfo\Tests\Fixtures\DummyBackedEnum;
 use Symfony\Component\TypeInfo\Tests\Fixtures\DummyCollection;
 use Symfony\Component\TypeInfo\Tests\Fixtures\DummyEnum;
+use Symfony\Component\TypeInfo\Tests\Fixtures\DummyWithConstants;
 use Symfony\Component\TypeInfo\Tests\Fixtures\DummyWithTemplates;
 use Symfony\Component\TypeInfo\Type;
 use Symfony\Component\TypeInfo\TypeContext\TypeContext;
@@ -89,6 +90,7 @@ public static function resolveDataProvider(): iterable
         yield [Type::null(), 'null'];
         yield [Type::string(), '"string"'];
         yield [Type::true(), 'true'];
+        yield [Type::string(), DummyWithConstants::class.'::DUMMY_*'];
 
         // identifiers
         yield [Type::bool(), 'bool'];
diff --git a/src/Symfony/Component/TypeInfo/TypeResolver/StringTypeResolver.php b/src/Symfony/Component/TypeInfo/TypeResolver/StringTypeResolver.php
@@ -18,6 +18,7 @@
 use PHPStan\PhpDocParser\Ast\ConstExpr\ConstExprNullNode;
 use PHPStan\PhpDocParser\Ast\ConstExpr\ConstExprStringNode;
 use PHPStan\PhpDocParser\Ast\ConstExpr\ConstExprTrueNode;
+use PHPStan\PhpDocParser\Ast\ConstExpr\ConstFetchNode;
 use PHPStan\PhpDocParser\Ast\Type\ArrayShapeNode;
 use PHPStan\PhpDocParser\Ast\Type\ArrayTypeNode;
 use PHPStan\PhpDocParser\Ast\Type\CallableTypeNode;
@@ -125,7 +126,8 @@ private function getTypeFromNode(TypeNode $node, ?TypeContext $typeContext): Typ
                 ConstExprFloatNode::class => Type::float(),
                 ConstExprIntegerNode::class => Type::int(),
                 ConstExprNullNode::class => Type::null(),
-                ConstExprStringNode::class => Type::string(),
+                ConstExprStringNode::class,
+                ConstFetchNode::class => Type::string(),
                 ConstExprTrueNode::class => Type::true(),
                 default => throw new \DomainException(\sprintf('Unhandled "%s" constant expression.', $node->constExpr::class)),
             };
