[WIP] [Routing] set aliases in Route attribute

damienfern · damienfern · commit 354b65bcc81f · 2024-11-09T13:09:05.000+01:00
diff --git a/src/Symfony/Component/Routing/Attribute/Route.php b/src/Symfony/Component/Routing/Attribute/Route.php
@@ -46,6 +46,7 @@ public function __construct(
         private array $requirements = [],
         private array $options = [],
         private array $defaults = [],
+        private array $alias = [],
         private ?string $host = null,
         array|string $methods = [],
         array|string $schemes = [],
@@ -64,7 +65,7 @@ public function __construct(
         }
         $this->setMethods($methods);
         $this->setSchemes($schemes);
-
+        $this->setAliases($alias);
         if (null !== $locale) {
             $this->defaults['_locale'] = $locale;
         }
@@ -201,6 +202,16 @@ public function getEnv(): ?string
     {
         return $this->env;
     }
+
+    public function getAliases(): array
+    {
+        return $this->alias;
+    }
+
+    public function setAliases(array $alias): void
+    {
+        $this->alias = $alias;
+    }
 }
 
 if (!class_exists(\Symfony\Component\Routing\Annotation\Route::class, false)) {
diff --git a/src/Symfony/Component/Routing/CHANGELOG.md b/src/Symfony/Component/Routing/CHANGELOG.md
@@ -4,8 +4,9 @@ CHANGELOG
 7.2
 ---
 
- * Add the `Requirement::UID_RFC9562` constant to validate UUIDs in the RFC 9562 format
- * Deprecate the `AttributeClassLoader::$routeAnnotationClass` property
+* Add aliases in the Route attribute
+* Add the `Requirement::UID_RFC9562` constant to validate UUIDs in the RFC 9562 format
+* Deprecate the `AttributeClassLoader::$routeAnnotationClass` property
 
 7.1
 ---
diff --git a/src/Symfony/Component/Routing/Loader/AttributeClassLoader.php b/src/Symfony/Component/Routing/Loader/AttributeClassLoader.php
@@ -230,6 +230,11 @@ protected function addRoute(RouteCollection $collection, object $attr, array $gl
             } else {
                 $collection->add($name, $route, $priority);
             }
+            if (0 !== count($attr->getAliases())) {
+                foreach ($attr->getAliases() as $alias) {
+                    $collection->addAlias($alias, $name);
+                }
+            }
         }
     }
 
diff --git a/src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/AliasRouteController.php b/src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/AliasRouteController.php
@@ -0,0 +1,13 @@
+<?php
+
+namespace Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures;
+
+use Symfony\Component\Routing\Attribute\Route;
+
+class AliasRouteController
+{
+    #[Route('/path', name: 'action_with_alias', alias: ['alias', 'completely_different_name'])]
+    public function action()
+    {
+    }
+}
diff --git a/src/Symfony/Component/Routing/Tests/Loader/AttributeClassLoaderTest.php b/src/Symfony/Component/Routing/Tests/Loader/AttributeClassLoaderTest.php
@@ -16,6 +16,7 @@
 use Symfony\Component\Routing\Exception\LogicException;
 use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\AbstractClassController;
 use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\ActionPathController;
+use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\AliasRouteController;
 use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\BazClass;
 use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\DefaultValueController;
 use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\EncodingClass;
@@ -364,4 +365,13 @@ public function testDefaultRouteName()
 
         $this->assertSame('symfony_component_routing_tests_fixtures_attributefixtures_encodingclass_routeàction', $defaultName);
     }
+
+    public function testAliases(): void {
+        $routes = $this->loader->load(AliasRouteController::class);
+        $route = $routes->get('action_with_alias');
+        $this->assertCount(1, $routes);
+        $this->assertEquals('/path', $route->getPath());
+        $this->assertEquals(new Alias('action_with_alias'), $routes->getAlias('alias'));
+        $this->assertEquals(new Alias('action_with_alias'), $routes->getAlias('completely_different_name'));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -230,6 +230,11 @@ protected function addRoute(RouteCollection $collection, object $attr, array $gl`
`230`	`230`	`} else {`
`231`	`231`	`$collection->add($name, $route, $priority);`
`232`	`232`	`}`
	`233`	`+ if (0 !== count($attr->getAliases())) {`
	`234`	`+ foreach ($attr->getAliases() as $alias) {`
	`235`	`+ $collection->addAlias($alias, $name);`
	`236`	`+ }`
	`237`	`+ }`
`233`	`238`	`}`
`234`	`239`	`}`
`235`	`240`