[JsonStreamer] Make cache warmers non-optional

mtarld · mtarld · commit 32fc3c6c1c56 · 2025-10-14T11:53:51.000+02:00
diff --git a/src/Symfony/Component/JsonStreamer/CacheWarmer/LazyGhostCacheWarmer.php b/src/Symfony/Component/JsonStreamer/CacheWarmer/LazyGhostCacheWarmer.php
@@ -55,7 +55,7 @@ public function warmUp(string $cacheDir, ?string $buildDir = null): array
 
     public function isOptional(): bool
     {
-        return true;
+        return false;
     }
 
     /**
diff --git a/src/Symfony/Component/JsonStreamer/CacheWarmer/StreamerCacheWarmer.php b/src/Symfony/Component/JsonStreamer/CacheWarmer/StreamerCacheWarmer.php
@@ -70,7 +70,7 @@ public function warmUp(string $cacheDir, ?string $buildDir = null): array
 
     public function isOptional(): bool
     {
-        return true;
+        return false;
     }
 
     private function warmUpStreamWriter(Type $type): void
diff --git a/src/Symfony/Component/JsonStreamer/DependencyInjection/StreamablePass.php b/src/Symfony/Component/JsonStreamer/DependencyInjection/StreamablePass.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\JsonStreamer\DependencyInjection;
 
+use Symfony\Component\Config\Resource\ReflectionClassResource;
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 
@@ -40,6 +41,8 @@ public function process(ContainerBuilder $container): void
                     'object' => $tag['object'],
                     'list' => $tag['list'],
                 ];
+
+                $container->addResource(new ReflectionClassResource(new \ReflectionClass($className)));
             }
 
             $container->removeDefinition($id);
diff --git a/src/Symfony/Component/JsonStreamer/Tests/DependencyInjection/StreamablePassTest.php b/src/Symfony/Component/JsonStreamer/Tests/DependencyInjection/StreamablePassTest.php
@@ -14,6 +14,9 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\JsonStreamer\DependencyInjection\StreamablePass;
+use Symfony\Component\JsonStreamer\Tests\Fixtures\Model\ClassicDummy;
+use Symfony\Component\JsonStreamer\Tests\Fixtures\Model\DummyWithArray;
+use Symfony\Component\JsonStreamer\Tests\Fixtures\Model\DummyWithGenerics;
 
 class StreamablePassTest extends TestCase
 {
@@ -25,17 +28,17 @@ public function testSetStreamable()
         $container->register('.json_streamer.cache_warmer.streamer')->setArguments([null]);
         $container->register('.json_streamer.cache_warmer.lazy_ghost')->setArguments([null]);
 
-        $container->register('streamable')->setClass('Foo')->addTag('json_streamer.streamable', ['object' => true, 'list' => true]);
-        $container->register('abstractStreamable')->setClass('Bar')->addTag('json_streamer.streamable', ['object' => true, 'list' => true])->setAbstract(true);
-        $container->register('notStreamable')->setClass('Baz');
+        $container->register('streamable')->setClass(ClassicDummy::class)->addTag('json_streamer.streamable', ['object' => true, 'list' => true]);
+        $container->register('abstractStreamable')->setClass(DummyWithArray::class)->addTag('json_streamer.streamable', ['object' => true, 'list' => true])->setAbstract(true);
+        $container->register('notStreamable')->setClass(DummyWithGenerics::class);
 
         $pass = new StreamablePass();
         $pass->process($container);
 
         $streamerCacheWarmer = $container->getDefinition('.json_streamer.cache_warmer.streamer');
         $lazyGhostCacheWarmer = $container->getDefinition('.json_streamer.cache_warmer.lazy_ghost');
 
-        $this->assertSame(['Foo' => ['object' => true, 'list' => true]], $streamerCacheWarmer->getArgument(0));
-        $this->assertSame(['Foo'], $lazyGhostCacheWarmer->getArgument(0));
+        $this->assertSame([ClassicDummy::class => ['object' => true, 'list' => true]], $streamerCacheWarmer->getArgument(0));
+        $this->assertSame([ClassicDummy::class], $lazyGhostCacheWarmer->getArgument(0));
     }
 }
diff --git a/src/Symfony/Component/JsonStreamer/composer.json b/src/Symfony/Component/JsonStreamer/composer.json
@@ -26,6 +26,7 @@
     },
     "require-dev": {
         "phpstan/phpdoc-parser": "^1.0",
+        "symfony/config": "^7.2",
         "symfony/dependency-injection": "^7.2",
         "symfony/http-kernel": "^7.2"
     },

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public function warmUp(string $cacheDir, ?string $buildDir = null): array`
`55`	`55`
`56`	`56`	`public function isOptional(): bool`
`57`	`57`	`{`
`58`		`- return true;`
	`58`	`+ return false;`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public function warmUp(string $cacheDir, ?string $buildDir = null): array`
`70`	`70`
`71`	`71`	`public function isOptional(): bool`
`72`	`72`	`{`
`73`		`- return true;`
	`73`	`+ return false;`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`private function warmUpStreamWriter(Type $type): void`