feature #37371 [Translation] Add support for calling 'trans' with ICU formatted messages (someonewithpc)

fabpot · fabpot · commit 241af8057fc8 · 2020-08-30T09:19:50.000+02:00
This PR was squashed before being merged into the 5.2-dev branch. Discussion ---------- [Translation] Add support for calling 'trans' with ICU formatted messages | Q | A | ------------- | --- | Branch? | master | Bug fix? | maybe, see #37228 | New feature? | yes | Deprecations? | no | Tickets | Fix #37228 | License | MIT | Doc PR | symfony/symfony-docs#13875 Motivation: ``` $apples = [0 => 'No apples', 1 => '1 apple', '# apples']; echo _m($apples, ['count' => 0]); // Outputs 'No apples' echo _m($apples, ['count' => 2]); // Outputs '2 apples' ``` where `_m` is a wrapper my application is using, but we obviously don't want to replicate many of the effort of the translation component, so it relies on `trans`. This wrapper itself could be integrated into Symfony, if deemed appropriate. See #37228 Commits ------- d2ec41f [Translation] Add support for calling 'trans' with ICU formatted messages
diff --git a/src/Symfony/Component/Translation/CHANGELOG.md b/src/Symfony/Component/Translation/CHANGELOG.md
@@ -4,6 +4,7 @@ CHANGELOG
 5.2.0
 -----
 
+ * added support for calling `trans` with ICU formatted messages
  * added `PseudoLocalizationTranslator`
  * added `Translatable` objects that represent a message that can be translated
  * added the `t()` function to easily create `Translatable` objects
diff --git a/src/Symfony/Component/Translation/Tests/TranslatorTest.php b/src/Symfony/Component/Translation/Tests/TranslatorTest.php
@@ -368,6 +368,14 @@ public function testTrans($expected, $id, $translation, $parameters, $locale, $d
         $this->assertEquals($expected, $translator->trans($id, $parameters, $domain, $locale));
     }
 
+    /**
+     * @dataProvider getTransICUTests
+     */
+    public function testTransICU(...$args)
+    {
+        $this->testTrans(...$args);
+    }
+
     /**
      * @dataProvider getInvalidLocalesTests
      */
@@ -444,6 +452,17 @@ public function getTransTests()
         ];
     }
 
+    public function getTransICUTests()
+    {
+        $id = '{apples, plural, =0 {There are no apples} one {There is one apple} other {There are # apples}}';
+
+        return [
+            ['There are no apples', $id, $id, ['{apples}' => 0], 'en', 'test'.MessageCatalogue::INTL_DOMAIN_SUFFIX],
+            ['There is one apple',  $id, $id, ['{apples}' => 1], 'en', 'test'.MessageCatalogue::INTL_DOMAIN_SUFFIX],
+            ['There are 3 apples',  $id, $id, ['{apples}' => 3], 'en', 'test'.MessageCatalogue::INTL_DOMAIN_SUFFIX],
+        ];
+    }
+
     public function getFlattenedTransTests()
     {
         $messages = [
diff --git a/src/Symfony/Component/Translation/Translator.php b/src/Symfony/Component/Translation/Translator.php
@@ -214,7 +214,10 @@ public function trans(?string $id, array $parameters = [], string $domain = null
             }
         }
 
-        if ($this->hasIntlFormatter && $catalogue->defines($id, $domain.MessageCatalogue::INTL_DOMAIN_SUFFIX)) {
+        $len = \strlen(MessageCatalogue::INTL_DOMAIN_SUFFIX);
+        if ($this->hasIntlFormatter
+            && ($catalogue->defines($id, $domain.MessageCatalogue::INTL_DOMAIN_SUFFIX)
+                || 0 == substr_compare($domain, MessageCatalogue::INTL_DOMAIN_SUFFIX, -$len, $len))) {
             return $this->formatter->formatIntl($catalogue->get($id, $domain), $locale, $parameters);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,10 @@ public function trans(?string $id, array $parameters = [], string $domain = null`
`214`	`214`	`}`
`215`	`215`	`}`
`216`	`216`
`217`		`- if ($this->hasIntlFormatter && $catalogue->defines($id, $domain.MessageCatalogue::INTL_DOMAIN_SUFFIX)) {`
	`217`	`+ $len = \strlen(MessageCatalogue::INTL_DOMAIN_SUFFIX);`
	`218`	`+ if ($this->hasIntlFormatter`
	`219`	`+ && ($catalogue->defines($id, $domain.MessageCatalogue::INTL_DOMAIN_SUFFIX)`
	`220`	`+ \|\| 0 == substr_compare($domain, MessageCatalogue::INTL_DOMAIN_SUFFIX, -$len, $len))) {`
`218`	`221`	`return $this->formatter->formatIntl($catalogue->get($id, $domain), $locale, $parameters);`
`219`	`222`	`}`
`220`	`223`