Skip to content

Commit 239ea41

Browse files
fabpotfabpot
committed
[Messenger] Rename some classes
1 parent 40af2ea commit 239ea41

File tree

5 files changed

+16
-16
lines changed

5 files changed

+16
-16
lines changed

‎src/Symfony/Component/Messenger/CHANGELOG.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ CHANGELOG
55
---
66

77
* Add new `messenger:stats` command that return a list of transports with their "to be processed" message count
8-
* Add `ViaSenderStamp` to change the transport while dispatching a message
8+
* Add `SenderNamesStamp` to change the transport while dispatching a message
99

1010
6.1
1111
---

src/Symfony/Component/Messenger/Stamp/OverrideSendersStamp.php renamed to src/Symfony/Component/Messenger/Stamp/SenderNamesStamp.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@
1212
namespace Symfony\Component\Messenger\Stamp;
1313

1414
/**
15-
* Apply this stamp to change sender to be used instead of the one from configuration file.
15+
* Stamp used to override the senders specified in the configuration file.
1616
*/
17-
final class ViaSenderStamp implements StampInterface
17+
final class SenderNamesStamp implements StampInterface
1818
{
1919
/**
20-
* @param string[] $senders New senders to be used with message
20+
* @param string[] $senders Senders to be used for the message
2121
*/
2222
public function __construct(private array $senders)
2323
{
2424
}
2525

26-
public function getSenders(): array
26+
public function getSenderNames(): array
2727
{
2828
return $this->senders;
2929
}

src/Symfony/Component/Messenger/Tests/Stamp/OverrideSendersStampTest.php renamed to src/Symfony/Component/Messenger/Tests/Stamp/SenderNamesStampTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@
1212
namespace Symfony\Component\Messenger\Tests\Stamp;
1313

1414
use PHPUnit\Framework\TestCase;
15-
use Symfony\Component\Messenger\Stamp\ViaSenderStamp;
15+
use Symfony\Component\Messenger\Stamp\SenderNamesStamp;
1616

17-
class ViaSenderStampTest extends TestCase
17+
class SenderNamesStampTest extends TestCase
1818
{
1919
public function testGetSenders()
2020
{
2121
$configuredSenders = ['first_transport', 'second_transport', 'other_transport'];
22-
$stamp = new ViaSenderStamp($configuredSenders);
23-
$stampSenders = $stamp->getSenders();
22+
$stamp = new SenderNamesStamp($configuredSenders);
23+
$stampSenders = $stamp->getSenderNames();
2424
$this->assertEquals(\count($configuredSenders), \count($stampSenders));
2525

2626
foreach ($configuredSenders as $key => $sender) {

‎src/Symfony/Component/Messenger/Tests/Transport/Sender/SendersLocatorTest.php‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
use PHPUnit\Framework\TestCase;
1515
use Psr\Container\ContainerInterface;
1616
use Symfony\Component\Messenger\Envelope;
17-
use Symfony\Component\Messenger\Stamp\ViaSenderStamp;
17+
use Symfony\Component\Messenger\Stamp\SenderNamesStamp;
1818
use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
1919
use Symfony\Component\Messenger\Tests\Fixtures\SecondMessage;
2020
use Symfony\Component\Messenger\Transport\Sender\SenderInterface;
@@ -36,7 +36,7 @@ public function testItReturnsTheSenderBasedOnTheMessageClass()
3636
$this->assertSame([], iterator_to_array($locator->getSenders(new Envelope(new SecondMessage()))));
3737
}
3838

39-
public function testItReturnsTheSenderBasedOnViaSenderStamp()
39+
public function testItReturnsTheSenderBasedOnSenderNamesStamp()
4040
{
4141
$mySender = $this->createMock(SenderInterface::class);
4242
$otherSender = $this->createMock(SenderInterface::class);
@@ -48,7 +48,7 @@ public function testItReturnsTheSenderBasedOnViaSenderStamp()
4848
DummyMessage::class => ['my_sender'],
4949
], $sendersLocator);
5050

51-
$this->assertSame(['other_sender' => $otherSender], iterator_to_array($locator->getSenders(new Envelope(new DummyMessage('a'), [new ViaSenderStamp(['other_sender'])]))));
51+
$this->assertSame(['other_sender' => $otherSender], iterator_to_array($locator->getSenders(new Envelope(new DummyMessage('a'), [new SenderNamesStamp(['other_sender'])]))));
5252
$this->assertSame([], iterator_to_array($locator->getSenders(new Envelope(new SecondMessage()))));
5353
}
5454

‎src/Symfony/Component/Messenger/Transport/Sender/SendersLocator.php‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
use Symfony\Component\Messenger\Envelope;
1616
use Symfony\Component\Messenger\Exception\RuntimeException;
1717
use Symfony\Component\Messenger\Handler\HandlersLocator;
18-
use Symfony\Component\Messenger\Stamp\ViaSenderStamp;
18+
use Symfony\Component\Messenger\Stamp\SenderNamesStamp;
1919

2020
/**
2121
* Maps a message to a list of senders.
@@ -42,10 +42,10 @@ public function __construct(array $sendersMap, ContainerInterface $sendersLocato
4242
*/
4343
public function getSenders(Envelope $envelope): iterable
4444
{
45-
if (\count($envelope->all(ViaSenderStamp::class)) > 0) {
46-
$viaSenderStamp = $envelope->last(ViaSenderStamp::class);
45+
if ($envelope->all(SenderNamesStamp::class)) {
46+
$senderNamesStamp = $envelope->last(SenderNamesStamp::class);
4747

48-
foreach ($viaSenderStamp->getSenders() as $senderAlias) {
48+
foreach ($senderNamesStamp->getSenderNames() as $senderAlias) {
4949
yield from $this->getSenderFromAlias($senderAlias);
5050
}
5151

0 commit comments

Comments
 (0)