Changed after code review

jschaedl · jschaedl · commit 1dab3f54e425 · 2020-08-07T07:54:09.000+02:00
diff --git a/src/Symfony/Component/Notifier/CHANGELOG.md b/src/Symfony/Component/Notifier/CHANGELOG.md
@@ -9,8 +9,8 @@ CHANGELOG
  * The `EmailRecipientInterface` and `RecipientInterface` were introduced.
  * Added `email` and and `phone` properties to `Recipient`.
  * [BC BREAK] Changed the type-hint of the `$recipient` argument in the `as*Message()`
-  of the `EmailNotificationInterface` and `SmsNotificationInterface` to `EmailRecipientInterface`
-  and `SmsRecipientInterface`.
+   of the `EmailNotificationInterface` and `SmsNotificationInterface` to `EmailRecipientInterface`
+   and `SmsRecipientInterface`.
  * [BC BREAK] Removed the `AdminRecipient`.
  * The `EmailRecipientInterface` and `SmsRecipientInterface` now extend the `RecipientInterface`.
  * The `EmailRecipient` and `SmsRecipient` were introduced.
diff --git a/src/Symfony/Component/Notifier/Recipient/Recipient.php b/src/Symfony/Component/Notifier/Recipient/Recipient.php
@@ -26,7 +26,7 @@ class Recipient implements EmailRecipientInterface, SmsRecipientInterface
 
     public function __construct(string $email = '', string $phone = '')
     {
-        if (empty(trim($email)) && empty(trim($phone))) {
+        if ('' === $email && '' === $phone) {
             throw new InvalidArgumentException(sprintf('"%s" needs an email or a phone but both cannot be empty.', static::class));
         }
 
@@ -45,6 +45,8 @@ public function email(string $email): self
     }
 
     /**
+     * Sets the phone number (no spaces, international code like in +3312345678).
+     *
      * @return $this
      */
     public function phone(string $phone): self

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class Recipient implements EmailRecipientInterface, SmsRecipientInterface`
`26`	`26`
`27`	`27`	`public function __construct(string $email = '', string $phone = '')`
`28`	`28`	`{`
`29`		`- if (empty(trim($email)) && empty(trim($phone))) {`
	`29`	`+ if ('' === $email && '' === $phone) {`
`30`	`30`	`throw new InvalidArgumentException(sprintf('"%s" needs an email or a phone but both cannot be empty.', static::class));`
`31`	`31`	`}`
`32`	`32`
`@@ -45,6 +45,8 @@ public function email(string $email): self`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`/**`
	`48`	`+ * Sets the phone number (no spaces, international code like in +3312345678).`
	`49`	`+ *`
`48`	`50`	`* @return $this`
`49`	`51`	`*/`
`50`	`52`	`public function phone(string $phone): self`