bug #62685 [DependencyInjection] Fix PriorityTaggedServiceTrait when tag attributes are not a list (GromNaN)

nicolas-grekas · nicolas-grekas · commit 16389f6b815d · 2025-12-08T07:48:51.000+01:00
This PR was merged into the 7.3 branch. Discussion ---------- [DependencyInjection] Fix `PriorityTaggedServiceTrait` when tag attributes are not a list | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Alternative to #62683 Ensure the attributes of the tag are in a list before iterating on them using sequential indexes. > In symfony/monolog-bundle#485, the tag attributes are filtered, which generates gaps in the keys. The PR mentioned above causes MonologBundle to fail. This can be fixed by symfony/monolog-bundle#563. However I believe the issue should also be addressed in Symfony. Commits ------- 5a4a036 [DependencyInjection] Fix PriorityTaggedServiceTrait when tag attributes are not a list
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php b/src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
@@ -81,6 +81,7 @@ private function findAndSortTaggedServices(string|TaggedIteratorArgument $tagNam
                 $phpAttributes = [];
             }
 
+            $attributes = array_values($attributes);
             for ($i = 0; $i < \count($attributes); ++$i) {
                 if (!($attribute = $attributes[$i]) && $phpAttributes) {
                     array_splice($attributes, $i--, 1, $phpAttributes);
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/PriorityTaggedServiceTraitTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/PriorityTaggedServiceTraitTest.php
@@ -449,6 +449,21 @@ public function testMultiTagsWithMixedAttributesAndNonStaticDefault()
         $this->assertArrayHasKey('foo', $services);
         $this->assertArrayHasKey('default', $services);
     }
+
+    public function testTagAttributesAreNotAList()
+    {
+        $container = new ContainerBuilder();
+        $container->register('service1')->setTags([
+            'my_custom_tag' => [1 => ['attributes' => 'not_a_list']],
+        ]);
+
+        $priorityTaggedServiceTraitImplementation = new PriorityTaggedServiceTraitImplementation();
+
+        $expected = [
+            new Reference('service1'),
+        ];
+        $this->assertEquals($expected, $priorityTaggedServiceTraitImplementation->test('my_custom_tag', $container));
+    }
 }
 
 class PriorityTaggedServiceTraitImplementation

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ private function findAndSortTaggedServices(string\|TaggedIteratorArgument $tagNam`
`81`	`81`	`$phpAttributes = [];`
`82`	`82`	`}`
`83`	`83`
	`84`	`+ $attributes = array_values($attributes);`
`84`	`85`	`for ($i = 0; $i < \count($attributes); ++$i) {`
`85`	`86`	`if (!($attribute = $attributes[$i]) && $phpAttributes) {`
`86`	`87`	`array_splice($attributes, $i--, 1, $phpAttributes);`