feature #37951 [FrameworkBundle] Make AbstractPhpFileCacheWarmer public (ossinkine)

fabpot · fabpot · commit 160b5982cf74 · 2020-08-26T09:58:08.000+02:00
This PR was submitted for the 3.4 branch but it was merged into the 5.2-dev branch instead. Discussion ---------- [FrameworkBundle] Make AbstractPhpFileCacheWarmer public | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | License | MIT Introducing the PhpArrayAdapter was a great feature. It has proven itself well in the production. Actually, using the adapter is closely related to warming up the cache for it. FrameworkBundle has an AbstractPhpFileCacheWarmer for conveniently creating a custom warmer. But using it outside of the FrameworkBundle becomes more complicated because it is marked as internal. I propose making it public and allow it to be used outside of the FrameworkBundle. For example, I've proposed to cache Doctrine metadata using PhpArrayAdapter and the implementation uses AbstractPhpFileCacheWarmer doctrine/DoctrineBundle#1196 Commits ------- a0fb442 Make AbstractPhpFileCacheWarmer public
diff --git a/src/Symfony/Bundle/FrameworkBundle/CacheWarmer/AbstractPhpFileCacheWarmer.php b/src/Symfony/Bundle/FrameworkBundle/CacheWarmer/AbstractPhpFileCacheWarmer.php
@@ -17,9 +17,6 @@
 use Symfony\Component\Config\Resource\ClassExistenceResource;
 use Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerInterface;
 
-/**
- * @internal
- */
 abstract class AbstractPhpFileCacheWarmer implements CacheWarmerInterface
 {
     private $phpArrayFile;

Original file line number	Diff line number	Diff line change
`@@ -17,9 +17,6 @@`
`17`	`17`	`use Symfony\Component\Config\Resource\ClassExistenceResource;`
`18`	`18`	`use Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerInterface;`
`19`	`19`
`20`		`-/**`
`21`		`- * @internal`
`22`		`- */`
`23`	`20`	`abstract class AbstractPhpFileCacheWarmer implements CacheWarmerInterface`
`24`	`21`	`{`
`25`	`22`	`private $phpArrayFile;`