Provide debug_backtrace with proper args

greg0ire · greg0ire · commit 0d826ae85dc4 · 2018-09-19T22:34:51.000+02:00
This would fail if we were using strict mode with php 7, because true is only a valid argument for php < 5.3.6. This was changed from PHP_VERSION_ID >= 50400 ? DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in #18272, but I do not understand why it was simplified, nor why DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
diff --git a/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php b/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php
@@ -72,7 +72,7 @@ public static function register($mode = 0)
             }
 
             $mode = $getMode();
-            $trace = debug_backtrace(true);
+            $trace = debug_backtrace();
             $group = 'other';
 
             $i = \count($trace);

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public static function register($mode = 0)`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`$mode = $getMode();`
`75`		`- $trace = debug_backtrace(true);`
	`75`	`+ $trace = debug_backtrace();`
`76`	`76`	`$group = 'other';`
`77`	`77`
`78`	`78`	`$i = \count($trace);`