Apply suggestions from code review

bobvandevijver · nicolas-grekas · bobvandevijver · commit 098586cb578b · 2025-06-27T18:02:09.000+02:00
Co-authored-by: Nicolas Grekas &lt;nicolas.grekas@gmail.com&gt;
diff --git a/src/Symfony/Component/Config/Builder/ConfigBuilderGenerator.php b/src/Symfony/Component/Config/Builder/ConfigBuilderGenerator.php
@@ -132,7 +132,7 @@ private function handleArrayNode(ArrayNode $node, ClassBuilder $class, string $n
 
         $hasNormalizationClosures = $this->hasNormalizationClosures($node);
         $comment = $this->getComment($node);
-        if ($hasNormalizationClosures && $paramType !== 'array') {
+        if ($hasNormalizationClosures && 'array' !== $paramType) {
             $comment = sprintf(" * @template TValue of %s\n * @param TValue \$value\n%s", $paramType, $comment);
             $comment .= sprintf(' * @return %s|$this'."\n", $childClass->getFqcn());
             $comment .= sprintf(' * @psalm-return (TValue is array ? %s : static)'."\n ", $childClass->getFqcn());
@@ -145,7 +145,7 @@ private function handleArrayNode(ArrayNode $node, ClassBuilder $class, string $n
             $node->getName(),
             $this->getType($childClass->getFqcn(), $hasNormalizationClosures)
         );
-        $body = $hasNormalizationClosures && $paramType !== 'array' ? '
+        $body = $hasNormalizationClosures && 'array' !== $paramType ? '
 COMMENTpublic function NAME(PARAM_TYPE $value = []): CLASS|static
 {
     if (!\is_array($value)) {
@@ -286,7 +286,7 @@ public function NAME(string $VAR, TYPE $VALUE): static
         $paramType = $this->getParamType($noKey ? $nodeParameterTypes : $prototypeParameterTypes);
 
         $comment = $this->getComment($node);
-        if ($hasNormalizationClosures && $paramType !== 'array') {
+        if ($hasNormalizationClosures && 'array' !== $paramType) {
             $comment = sprintf(" * @template TValue of %s\n * @param TValue \$value\n%s", $paramType, $comment);
             $comment .= sprintf(' * @return %s|$this'."\n", $childClass->getFqcn());
             $comment .= sprintf(' * @psalm-return (TValue is array ? %s : static)'."\n ", $childClass->getFqcn());
@@ -296,7 +296,7 @@ public function NAME(string $VAR, TYPE $VALUE): static
         }
 
         if ($noKey) {
-            $body = $hasNormalizationClosures && $paramType !== 'array' ? '
+            $body = $hasNormalizationClosures && 'array' !== $paramType ? '
 COMMENTpublic function NAME(PARAM_TYPE $value = []): CLASS|static
 {
     $this->_usedProperties[\'PROPERTY\'] = true;
@@ -321,7 +321,7 @@ public function NAME(string $VAR, TYPE $VALUE): static
                 'PARAM_TYPE' => $paramType,
             ]);
         } else {
-            $body = $hasNormalizationClosures && $paramType !== 'array' ? '
+            $body = $hasNormalizationClosures && 'array' !== $paramType ? '
 COMMENTpublic function NAME(string $VAR, PARAM_TYPE $VALUE = []): CLASS|static
 {
     if (!\is_array($VALUE)) {
