Edit comments

dunglas · dunglas · commit 056612c22a17 · 2016-03-25T22:07:47.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
@@ -142,6 +142,7 @@ private function autowireMethod($id, Definition $definition, \ReflectionMethod $
                         } elseif ($parameter->isDefaultValueAvailable()) {
                             $value = $parameter->getDefaultValue();
                         } else {
+                            // The exception code is set to 1 if the exception must be thrown even if it's a setter
                             if (1 === $e->getCode() || $isConstructor) {
                                 throw $e;
                             }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
@@ -641,7 +641,6 @@ public function setBar()
     public function setNotAutowireable(NotARealClass $n)
     {
         // should not be called
-        // ???
     }
 
     public function setArgCannotAutowire($foo)

Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,7 @@ private function autowireMethod($id, Definition $definition, \ReflectionMethod $`
`142`	`142`	`} elseif ($parameter->isDefaultValueAvailable()) {`
`143`	`143`	`$value = $parameter->getDefaultValue();`
`144`	`144`	`} else {`
	`145`	`+ // The exception code is set to 1 if the exception must be thrown even if it's a setter`
`145`	`146`	`if (1 === $e->getCode() \|\| $isConstructor) {`
`146`	`147`	`throw $e;`
`147`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -641,7 +641,6 @@ public function setBar()`
`641`	`641`	`public function setNotAutowireable(NotARealClass $n)`
`642`	`642`	`{`
`643`	`643`	`// should not be called`
`644`		`- // ???`
`645`	`644`	`}`
`646`	`645`
`647`	`646`	`public function setArgCannotAutowire($foo)`