feature #47445 [FrameworkBundle] Allow secrets vaults to be used directly outside Symfony (AndreasA)

nicolas-grekas · nicolas-grekas · commit 022b58fe38df · 2022-09-12T18:25:45.000+02:00
This PR was squashed before being merged into the 6.2 branch. Discussion ---------- [FrameworkBundle] Allow secrets vaults to be used directly outside Symfony | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | This PR removes the internal tag from the secrets vaults. This allows developers to use them directly without the need to use Symfony config etc. They still have to install the whole framework bundle but that just means an overhead during download, they are still able to directly instantiate the vault using `new SodiumVault(....)` for instance. Furthermore, by removing internal from the AbstractVault, it is possible to add a custom vault and specify it replacing the `secrets.vault` service for instance. See ticket: #44151 and previous PR: #45571 Commits ------- df953f0 [FrameworkBundle] Allow secrets vaults to be used directly outside Symfony
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -17,6 +17,7 @@ CHANGELOG
    tagged with `workflow.workflow`, and those with type=state_machine with
    `workflow.state_machine`
  * Add `rate_limiter` configuration option to `messenger.transport` to allow rate limited transports using the RateLimiter component
+ * Remove `@internal` tag from secret vaults to allow them to be used directly outside the framework bundle and custom vaults to be added
 
 6.1
 ---
diff --git a/src/Symfony/Bundle/FrameworkBundle/Secrets/AbstractVault.php b/src/Symfony/Bundle/FrameworkBundle/Secrets/AbstractVault.php
@@ -13,8 +13,6 @@
 
 /**
  * @author Nicolas Grekas <p@tchwork.com>
- *
- * @internal
  */
 abstract class AbstractVault
 {
diff --git a/src/Symfony/Bundle/FrameworkBundle/Secrets/DotenvVault.php b/src/Symfony/Bundle/FrameworkBundle/Secrets/DotenvVault.php
@@ -13,8 +13,6 @@
 
 /**
  * @author Nicolas Grekas <p@tchwork.com>
- *
- * @internal
  */
 class DotenvVault extends AbstractVault
 {
diff --git a/src/Symfony/Bundle/FrameworkBundle/Secrets/SodiumVault.php b/src/Symfony/Bundle/FrameworkBundle/Secrets/SodiumVault.php
@@ -18,8 +18,6 @@
  * @author Tobias Schultze <http://tobion.de>
  * @author Jérémy Derussé <jeremy@derusse.com>
  * @author Nicolas Grekas <p@tchwork.com>
- *
- * @internal
  */
 class SodiumVault extends AbstractVault implements EnvVarLoaderInterface
 {

Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,6 @@`
`13`	`13`
`14`	`14`	`/**`
`15`	`15`	`* @author Nicolas Grekas <p@tchwork.com>`
`16`		`- *`
`17`		`- * @internal`
`18`	`16`	`*/`
`19`	`17`	`abstract class AbstractVault`
`20`	`18`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,6 @@`
`18`	`18`	`* @author Tobias Schultze <http://tobion.de>`
`19`	`19`	`* @author Jérémy Derussé <jeremy@derusse.com>`
`20`	`20`	`* @author Nicolas Grekas <p@tchwork.com>`
`21`		`- *`
`22`		`- * @internal`
`23`	`21`	`*/`
`24`	`22`	`class SodiumVault extends AbstractVault implements EnvVarLoaderInterface`
`25`	`23`	`{`