Refactor Slug validation to use dynamic regex.

raffaelecarelle · raffaelecarelle · commit 0193d0c4af2f · 2025-01-05T16:52:44.000+01:00
Replaced the hardcoded SLUG_PATTERN with a dynamic regex property in the Slug constraint class. This allows greater flexibility by enabling customization of the slug validation pattern. Adjusted SlugValidator to use the new regex property.
diff --git a/src/Symfony/Component/Validator/Constraints/Slug.php b/src/Symfony/Component/Validator/Constraints/Slug.php
@@ -22,18 +22,20 @@
 class Slug extends Constraint
 {
     public const NOT_SLUG_ERROR = '14e6df1e-c8ab-4395-b6ce-04b132a3765e';
-    public const SLUG_PATTERN = '/^[a-z0-9]+(?:-[a-z0-9]+)*$/';
 
     public string $message = 'This value is not a valid slug.';
+    public string $regex = '/^[a-z0-9]+(?:-[a-z0-9]+)*$/';
 
     public function __construct(
         ?array $options = null,
+        ?string $regex = null,
         ?string $message = null,
         ?array $groups = null,
         mixed $payload = null,
     ) {
         parent::__construct($options, $groups, $payload);
 
         $this->message = $message ?? $this->message;
+        $this->regex = $regex ?? $this->regex;
     }
 }
diff --git a/src/Symfony/Component/Validator/Constraints/SlugValidator.php b/src/Symfony/Component/Validator/Constraints/SlugValidator.php
@@ -37,7 +37,7 @@ public function validate(mixed $value, Constraint $constraint): void
 
         $value = (string) $value;
 
-        if (0 === preg_match(Slug::SLUG_PATTERN, $value)) {
+        if (0 === preg_match($constraint->regex, $value)) {
             $this->context->buildViolation($constraint->message)
                 ->setParameter('{{ value }}', $this->formatValue($value))
                 ->setCode(Slug::NOT_SLUG_ERROR)

Original file line number	Diff line number	Diff line change
`@@ -22,18 +22,20 @@`
`22`	`22`	`class Slug extends Constraint`
`23`	`23`	`{`
`24`	`24`	`public const NOT_SLUG_ERROR = '14e6df1e-c8ab-4395-b6ce-04b132a3765e';`
`25`		`- public const SLUG_PATTERN = '/^[a-z0-9]+(?:-[a-z0-9]+)*$/';`
`26`	`25`
`27`	`26`	`public string $message = 'This value is not a valid slug.';`
	`27`	`+ public string $regex = '/^[a-z0-9]+(?:-[a-z0-9]+)*$/';`
`28`	`28`
`29`	`29`	`public function __construct(`
`30`	`30`	`?array $options = null,`
	`31`	`+ ?string $regex = null,`
`31`	`32`	`?string $message = null,`
`32`	`33`	`?array $groups = null,`
`33`	`34`	`mixed $payload = null,`
`34`	`35`	`) {`
`35`	`36`	`parent::__construct($options, $groups, $payload);`
`36`	`37`
`37`	`38`	`$this->message = $message ?? $this->message;`
	`39`	`+ $this->regex = $regex ?? $this->regex;`
`38`	`40`	`}`
`39`	`41`	`}`