Add #[NoDiscard] to the PHP 8.5 polyfill

Andrew Menino-Barlow · fabpot · commit 6fedf31ce4e3 · 2025-05-02T10:40:52.000+02:00
diff --git a/README.md b/README.md
@@ -4,6 +4,7 @@ Symfony Polyfill / Php85
 This component provides features added to PHP 8.5 core:
 
 - [`get_error_handler` and `get_exception_handler`](https://wiki.php.net/rfc/get-error-exception-handler)
+- [`NoDiscard`](https://wiki.php.net/rfc/marking_return_value_as_important)
 
 More information can be found in the
 [main Polyfill README](https://github.com/symfony/polyfill/blob/main/README.md).
diff --git a/Resources/stubs/NoDiscard.php b/Resources/stubs/NoDiscard.php
@@ -0,0 +1,23 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+if (\PHP_VERSION_ID < 80500) {
+    #[Attribute(Attribute::TARGET_METHOD | Attribute::TARGET_FUNCTION)]
+    final class NoDiscard
+    {
+        public ?string $message;
+
+        public function __construct(?string $message = null)
+        {
+            $this->message = $message;
+        }
+    }
+}
diff --git a/composer.json b/composer.json
@@ -20,7 +20,8 @@
     },
     "autoload": {
         "psr-4": { "Symfony\\Polyfill\\Php85\\": "" },
-        "files": [ "bootstrap.php" ]
+        "files": [ "bootstrap.php" ],
+        "classmap": [ "Resources/stubs" ]
     },
     "minimum-stability": "dev",
     "extra": {
