bug #46676 [DoctrineBridge] Extend type guessing on enum fields (Gigino Chianese)

nicolas-grekas · nicolas-grekas · commit 0939810118d7 · 2022-06-19T13:38:56.000+02:00
This PR was merged into the 4.4 branch.

Discussion
----------

[DoctrineBridge] Extend type guessing on enum fields

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Doctrine supports enumType on array values, while the current implementation always assumes the value to be an enum object, if enumType is set.

If $typeOfField is `json_array` the collectionKeyType will still be null, while collectionValueType will be filled. That's because we have no way to determine from doctrine metadata, if the key is string or int. Yet I don't know if that's a valid thing to do, otherwise we should return null in that case.

Commits
-------

79239feaab CS fix
a9b0f43366 [DoctrineBridge] Extend type guessing on enum fields
diff --git a/DataCollector/MemoryDataCollector.php b/DataCollector/MemoryDataCollector.php
@@ -114,11 +114,8 @@ private function convertToBytes(string $memoryLimit)
 
         switch (substr($memoryLimit, -1)) {
             case 't': $max *= 1024;
-            // no break
             case 'g': $max *= 1024;
-            // no break
             case 'm': $max *= 1024;
-            // no break
             case 'k': $max *= 1024;
         }
 
