Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/http-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.0.1
Choose a base ref
...
head repository: symfony/http-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7.3
Choose a head ref
  • 6 commits
  • 7 files changed
  • 3 contributors

Commits on Dec 8, 2025

  1. Configuration menu
    Copy the full SHA
    0e38d39 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2025

  1. Configuration menu
    Copy the full SHA
    82bdbdf View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2025

  1. bug #62706 [HttpClient] Fix PHP deprecation when using `AmpHttpClient…

    …` (nicolas-grekas)
    
    This PR was merged into the 6.4 branch.
    
    Discussion
    ----------
    
    [HttpClient] Fix PHP deprecation when using `AmpHttpClient`
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | -
    | License       | MIT
    
    The deprecation happens when max_duration becomes a float in `AsyncContext::replaceRequest()`.
    
    Commits
    -------
    
    7026f9a6f28 [HttpClient] Fix PHP deprecation when using AmpHttpClient
    nicolas-grekas committed Dec 10, 2025
    Configuration menu
    Copy the full SHA
    6f5d003 View commit details
    Browse the repository at this point in the history
  2. [HttpClient] Fix ScopingHttpClient to always pass base_uri as `st…

    …ring` instead of parsed `array`
    santysisi authored and nicolas-grekas committed Dec 10, 2025
    Configuration menu
    Copy the full SHA
    e779304 View commit details
    Browse the repository at this point in the history
  3. bug #62699 [HttpClient] Fix ScopingHttpClient to always pass `base_…

    …uri` as `string` instead of parsed `array` (santysisi)
    
    This PR was merged into the 6.4 branch.
    
    Discussion
    ----------
    
    [HttpClient] Fix `ScopingHttpClient` to always pass `base_uri` as `string` instead of parsed `array`
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Issues        | Fix #62697
    | License       | MIT
    
    ### Problem
    * `ScopingHttpClient` parsed the `base_uri` into an `array` (scheme, path, query, etc.).
    * When passing this parsed value to a decorated client such as `RetryableHttpClient`, it caused errors.
    * According to the `HttpClientInterface` in Symfony Contracts, `base_uri` [must be a string](https://github.com/symfony/symfony/blob/6.4/src/Symfony/Contracts/HttpClient/HttpClientInterface.php#L45)
    
    ### Solution
    * Updated `ScopingHttpClient` so it always forwards `base_uri` as a `string`, not as a parsed array.
    * The change is applied for all decorated clients, not only `RetryableHttpClient`, since sending an `array` was not compliant with the `HttpClientInterface` comment.
    
    ### Additional Notes
    Originally, the idea was to apply this fix only when the decorated client was `RetryableHttpClient` and later add full support for parsed `base_uri` for `RetryableHttpClient` in version 8.1.
    However, after reviewing the `HttpClientInterface`, it became clear that sending a parsed `array` for `base_uri` was incorrect.
    Therefore, the behavior is now corrected universally.
    
    Commits
    -------
    
    9f80dd4f916 [HttpClient] Fix `ScopingHttpClient` to always pass `base_uri` as `string` instead of parsed `array`
    nicolas-grekas committed Dec 10, 2025
    Configuration menu
    Copy the full SHA
    0ef4c2b View commit details
    Browse the repository at this point in the history
  4. Merge branch '6.4' into 7.3

    * 6.4:
      [HttpClient] Fix `ScopingHttpClient` to always pass `base_uri` as `string` instead of parsed `array`
      [PropertyInfo] Fix PseudoType support in PhpDocTypeHelper
      fix: fix property info var tag extractor
      [DependencyInjection] Fix sharing services used only by tagged iterators
      [DependencyInjection] Handle recursive factory reentry for shared services in PhpDumper
      [HttpClient] Fix PHP deprecation when using AmpHttpClient
      [HttpClient] Fix copy as curl for arrays with resources & unreachable host
      [PropertyInfo] Fix inconsistency between isWritable and getWriteInfo
    nicolas-grekas committed Dec 10, 2025
    Configuration menu
    Copy the full SHA
    4f420c4 View commit details
    Browse the repository at this point in the history
Loading