bug #62763 [Console] Escape the description passed to the lazy command so the container can be build without wanting to replace the %not-a-param% to parameters

SiebeVE · SiebeVE · commit b52819a90fc9 · 2025-12-12T17:26:56.000+01:00
diff --git a/DependencyInjection/AddConsoleCommandPass.php b/DependencyInjection/AddConsoleCommandPass.php
@@ -135,10 +135,11 @@ public function process(ContainerBuilder $container): void
             }
 
             if ($description) {
-                $definition->addMethodCall('setDescription', [str_replace('%', '%%', $description)]);
+                $escapedDescription = str_replace('%', '%%', $description);
+                $definition->addMethodCall('setDescription', [$escapedDescription]);
 
                 $container->register('.'.$id.'.lazy', LazyCommand::class)
-                    ->setArguments([$commandName, $aliases, $description, $isHidden, new ServiceClosureArgument($lazyCommandRefs[$id])]);
+                    ->setArguments([$commandName, $aliases, $escapedDescription, $isHidden, new ServiceClosureArgument($lazyCommandRefs[$id])]);
 
                 $lazyCommandRefs[$id] = new Reference('.'.$id.'.lazy');
             }
diff --git a/Tests/DependencyInjection/AddConsoleCommandPassTest.php b/Tests/DependencyInjection/AddConsoleCommandPassTest.php
@@ -327,6 +327,25 @@ public function testProcessInvokableCommand()
         self::assertSame('The %command.name% command help content.', $command->getHelp());
     }
 
+    public function testProcessCommandWithDescriptionWithpercentageSigns()
+    {
+        $container = new ContainerBuilder();
+        $container
+            ->register(
+                'description_with_percentage_signs_command',
+                DescriptionWithPercentageSignsCommand::class,
+            )
+            ->addTag('console.command')
+        ;
+        $pass = new AddConsoleCommandPass();
+        $pass->process($container);
+
+        $command = $container->get('console.command_loader')->get('description-percentage-signs');
+
+        self::assertTrue($container->has('description_with_percentage_signs_command.command'));
+        self::assertSame('Just testing %percentage-signs%', $command->getDescription());
+    }
+
     public function testProcessInvokableSignalableCommand()
     {
         $container = new ContainerBuilder();
@@ -384,6 +403,14 @@ public function __invoke(): void
     }
 }
 
+#[AsCommand(name: 'description-percentage-signs', description: 'Just testing %percentage-signs%')]
+class DescriptionWithPercentageSignsCommand
+{
+    public function __invoke(): void
+    {
+    }
+}
+
 #[AsCommand(name: 'invokable-signalable', description: 'Just testing', help: 'The %command.name% help content.')]
 class InvokableSignalableCommand implements SignalableCommandInterface
 {

Original file line number	Diff line number	Diff line change
`@@ -135,10 +135,11 @@ public function process(ContainerBuilder $container): void`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`if ($description) {`
`138`		`- $definition->addMethodCall('setDescription', [str_replace('%', '%%', $description)]);`
	`138`	`+ $escapedDescription = str_replace('%', '%%', $description);`
	`139`	`+ $definition->addMethodCall('setDescription', [$escapedDescription]);`
`139`	`140`
`140`	`141`	`$container->register('.'.$id.'.lazy', LazyCommand::class)`
`141`		`- ->setArguments([$commandName, $aliases, $description, $isHidden, new ServiceClosureArgument($lazyCommandRefs[$id])]);`
	`142`	`+ ->setArguments([$commandName, $aliases, $escapedDescription, $isHidden, new ServiceClosureArgument($lazyCommandRefs[$id])]);`
`142`	`143`
`143`	`144`	`$lazyCommandRefs[$id] = new Reference('.'.$id.'.lazy');`
`144`	`145`	`}`