Speed operations on large responses - #61
Merged
Merged
Conversation
Keep a list of bytes instead of repeatedly appending (copying) to the bytes object.
Author
|
Address #60 |
Owner
|
I finally got a chance to understand the |
sylikc
reviewed
Dec 30, 2022
|
|
||
| # ====================================================================================================================== | ||
|
|
||
| def _get_buffer_end(buffer_list: List[bytes], bytes_needed: int) -> bytes: |
Owner
There was a problem hiding this comment.
thanks for adhering to the typing... the code is great!
sylikc
added a commit
that referenced
this pull request
Dec 30, 2022
This PR addresses the append() operations and uses lists and reverse() to speed up getting exiftool output Merge PR #61 by https://github.com/prutschman
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep a list of bytes instead of repeatedly appending (copying) to the bytes object.