BridgeJS: Add missing function keyword for namespace function declarations in TypeScript#592
Merged
kateinoigakukun merged 1 commit intoswiftwasm:mainfrom Feb 5, 2026
Conversation
…rations in TypeScript
kateinoigakukun
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
TIL 😅
BridgeJS was generating invalid TypeScript declarations for functions inside
namespaceblocks. The generated code looked like:This is a syntax error in TypeScript. Unlike class methods, functions inside TypeScript
namespacedeclarations require the explicitfunctionkeyword.Why this wasn't caught:
JavaScriptKit's
tsconfig.jsonuses"skipLibCheck": true, which skips type-checking of declaration files (.d.ts). The JavaScript E2E tests also passed because JavaScript doesn't havenamespace- it only sees the compiled runtime objects.Project which runs strict TypeScript type-checking (
tsc --noEmit) withoutskipLibCheckfails due to thatFix
Added the
functionkeyword prefix when generating function declarations inside namespaces: