[NFC] BridgeJS: Codegen code organisation and minor cleanups #482
+839
−864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kateinoigakukun
left a comment
kateinoigakukun
left a comment
There was a problem hiding this comment.
Currently SwiftPM has a performance issue that slows down the plugin compilation scaling on the number of source files. I just made a fix in SwiftPM side (swiftlang/swift-package-manager#9541) but I'm a bit hesitant to introduce a new separate file here. Would you mind merging the new file into an existing file for now?
krodak
force-pushed
the
chore/codegen-cleanup
branch
from
5d4a0a2 to
5a5d89b
Compare
krodak
force-pushed
the
chore/codegen-cleanup
branch
from
5a5d89b to
6f4b5b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR extracts some codegen code from ExportSwift, as it became a bit large due to new types introduction. Some additional minor cleanup introduced along the way.
Technical changes
ExportSwiftCodegens.swiftwith updated and a bit more consistent namingrenderFunctionBody(into:returnExpr:)helper)Testing
I've fixed testing regression I've introduced here when I was trying to run some tests on macOS with Swift 6.2.1 and disabled async tests, sorry for that 🙇🏻 🙏🏻