Implement RandomAccessCollection on JSArrayRef - #30
Merged
Conversation
j-f1
approved these changes
Aug 4, 2020
j-f1
left a comment
j-f1
left a comment
Member
There was a problem hiding this comment.
Great! The reason I went so far with the JSObjectRef is because an object typically has a bunch of properties and I wanted them to be accessible. Since arrays usually don’t have additional properties, I think that in the rare case there’s a conflict, it’s ok to have to use the subscript syntax.
Member
Author
|
After having another look, |
kateinoigakukun
approved these changes
Aug 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using
Intsubscripts onJSArrayRefinstances and makes the rest of the functions available from the relevant extensions. This may shadow some JavaScript functions with the same names (I don't remember any off the top of my head), but I hope that the added convenience is worth it.Also
.gitignoreis amended to include the.builddirectory created bymake test.