improved embedded support for building with SwiftPM - #267
Merged
Conversation
kateinoigakukun
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having to provide a lot of external flags to
swift buildis not ideal and basically breaks down when adding swift macro targets.This PR pushes the currently required flags into the
Package.swiftfile to allow building without any global flags provided to the build command.NOTE: The
__Embeddeddefine for the C target configuration did not play well with SwiftPM, so I based the logic on__wasi__(thanks @MaxDesiatov for the idea). However, it is not a perfect match and I hope a better solution will present itself in the future.