Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
.github/workflows/release.yaml
Outdated
| run: | | ||
| curl -X POST https://jenkins.superstream.ai/job/DevOps/job/Superstream/job/SDK/job/superstream-clients-python/buildWithParameters?DEPLOYMENT_TYPE=production \ | ||
| --user "team@superstream.ai:$JENKINS_TOKEN" \ | ||
| --header "Content-Type: application/json" No newline at end of file |
There was a problem hiding this comment.
Bug: Curl won't fail on HTTP errors, masking failures
The curl command is missing the --fail (or -f) flag. Without this flag, curl returns exit code 0 even when the HTTP request receives an error response (4xx or 5xx status codes). This means if Jenkins authentication fails, the job doesn't exist, or any server error occurs, the GitHub Actions workflow step will still report success. This could lead to developers believing a production deployment was triggered when it actually wasn't.
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| "https://jenkins.superstream.ai/job/DevOps/job/Superstream/job/SDK/job/superstream-clients-python/buildWithParameters?DEPLOYMENT_TYPE=production" \ | ||
| --user "team@superstream.ai:$JENKINS_TOKEN") | ||
|
|
||
| if [ $? -ne 0 ] || [ "$HTTP_STATUS" -ne 201 ] && [ "$HTTP_STATUS" -ne 200 ]; then |
There was a problem hiding this comment.
Bug: Operator precedence causes silent failure on curl errors
The shell conditional has incorrect operator precedence due to && and || being left-associative with equal precedence. The expression [ $? -ne 0 ] || [ "$HTTP_STATUS" -ne 201 ] && [ "$HTTP_STATUS" -ne 200 ] evaluates as ((curl_fail) OR (status != 201)) AND (status != 200) instead of the intended (curl_fail) OR ((status != 201) AND (status != 200)). This means if curl fails but HTTP_STATUS is 200 (possible with partial transfers or connection resets), the failure is silently ignored and the script reports success. Parentheses are needed to group the status checks.
2 participants
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
Checklist:
Reviewer Score - 100%
Meeting Task Specifications (50%)
Attention to Edge Cases (10%)
Writing Performant and Efficient Code (10%)
Addressing Feedback from Previous Code Reviews (10%)
Adherence to Coding Conventions (5%)
Writing Readable Code (5%)
Considering Aspects Not Explicitly Mentioned in the Specification (5%)
Completing Pull Request Form (2.5%)
Up to 2 Cycles of Code Review (2.5%)
Note
Add a GitHub Actions workflow that triggers a Jenkins production build on pushes to
latestaffectingpyproject.toml..github/workflows/release.yaml.pushtolatestwhenpyproject.tomlchanges.self-hostedrunner; checks out code.curlto trigger Jenkins job withDEPLOYMENT_TYPE=productionand validates HTTP200/201response.Written by Cursor Bugbot for commit cd23cf0. This will update automatically on new commits. Configure here.