Skip to content

scide: fix highlight selection by querying javascript, rather than QWebEngineView#7546

Open
JordanHendersonMusic wants to merge 1 commit into
supercollider:developfrom
JordanHendersonMusic:topic/fix-selection-in-helpbrowser
Open

scide: fix highlight selection by querying javascript, rather than QWebEngineView#7546
JordanHendersonMusic wants to merge 1 commit into
supercollider:developfrom
JordanHendersonMusic:topic/fix-selection-in-helpbrowser

Conversation

@JordanHendersonMusic

@JordanHendersonMusic JordanHendersonMusic commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

…## Purpose and Motivation

Fixes #7544

The highlighted selection wasn't updating in the help browser, don't know why, this just bypasses the qt stuff and goes straight to javascript.

Tested on linux, @prko, don't suppose you'd mind giving this a whirl?

Types of changes

  • Documentation
  • Bug fix
  • New feature
  • Breaking change

To-do list

  • Code is tested
  • All tests are passing
  • This PR is ready for review

@prko

prko commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for this fix.

I tested after the following steps:

  1. Launch SC
  2. Type SinOsc in the SC‑IDE code editor
  3. Press "Cmd/Ctrl" + "D"
  4. In the Examples section of the HelpBrowser, double‑click XLine on the last line of the CodeMirrorContainer:
    // phase modulation (see also PMOsc)
    { SinOsc.ar(800, SinOsc.ar(XLine.kr(1, 1000, 9), 0, 2pi), 0.25) }.play;
    
  5. When the Look Up Implementations window appears, press ESC
  6. Press "Shift" + "Enter" to evaluate that code line

Test results:

  • On Windows, it is fixed.
  • On macOS, it depends on the status of SC-IDE's editor:
    • When there is no open SCD file in SC-IDE's editor:
      The complete line of the code in CodeMirrorContainer is evaluated
    • When there is one or more open SCD file/files in SC-IDE's editor:
      The complete line of the code in the activated SCD file is evaluated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HelpBrowser in SC3.14.1 and SC3.15.0‑dev does not correctly parse SC code in various situations

2 participants