chore(deps): bump phoenix to 1.7.23#978
Open
MorganaFuture wants to merge 2 commits into
Open
Conversation
Phoenix 1.7.20 is affected by a high-severity advisory: long-poll NDJSON body splitting causes large memory allocation. Fixed in 1.7.22.
MorganaFuture
force-pushed
the
MorganaFuture/bump-phoenix-1.7.23
branch
from
c62dd83 to
533672b
Compare
Switch the security workflow trigger from pull_request_target to pull_request so that mix deps.audit and sobelow actually scan the code being proposed. With pull_request_target, actions/checkout defaults to the base branch (main), so PRs that fix or introduce vulnerabilities are scanned against main and the result is the same on every PR. The dependency-submission step still requires write access (which pull_request from forks cannot grant), so guard it with `if: github.event_name != 'pull_request'`. The submission continues to run on push to main and on the daily schedule.
Author
|
@v0idpwn Could you please take a look? Right now the pull_request_target trigger means this audit always scans main, not the PR diff. This pr should fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change?
Security dependency bump.
Current behavior
Phoenix 1.7.20 is affected by GHSA-628h-q48j-jr6q (high):
long-poll NDJSON body splitting causes large memory allocation.
mix deps.auditfails CI.New behavior
Bump Phoenix to 1.7.23 (first patched: 1.7.22).
~> 1.7.2inmix.exs already allows this — only mix.lock changes.