fix(telemetry): widen plan-presentation exposure event variant type to 5 variants - #50318
Merged
pamelachia merged 1 commit intoSep 14, 2026
Merged
Conversation
…to all 5 variants The pricing_panel_plan_presentation_experiment_exposed event's variant property only typed 3 of the experiment's 5 live variants, leaving fullscreen and fullscreen-gaps silently untyped and inconsistent with the source enum in plan-presentation.ts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gxb4n5ujMPeio1VmkowHc5
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
myerekapan
approved these changes
Sep 14, 2026
myerekapan
marked this pull request as ready for review
September 14, 2026 10:16
pamelachia
deleted the
fix/pricing-panel-plan-presentation-variant-types
branch
September 14, 2026 10:24
Contributor
Braintrust eval report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<!-- ccr-slack-attribution -->
Requested by Pam Chia · Slack thread
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
Bug fix (telemetry type).
What is the current behavior?
The
pricing_panel_plan_presentation_experiment_exposedevent'svariantproperty inpackages/common/telemetry-constants.tsonly types 3 of the experiment's 5 live variants ('control' | 'parity' | 'gaps'), even though the experiment source inplan-presentation.tsdefines and actively uses 5:control,parity,gaps,fullscreen,fullscreen-gaps. The two full-screen variants are silently untyped in the telemetry catalog.What is the new behavior?
The
variantproperty is widened to'control' | 'parity' | 'gaps' | 'fullscreen' | 'fullscreen-gaps', matching the exact casing ofPLAN_PRESENTATION_VARIANTSin the experiment source, and consistent with how other experiment-variant unions in the same file (e.g.rlsOptionVariant) are kept in sync with their source enum.Additional context
Linear: GROWTH-1234
🤖 Generated with Claude Code
https://claude.ai/code/session_01Gxb4n5ujMPeio1VmkowHc5
Generated by Claude Code