Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Superseded by a newer AI review
🤖 AI Review
Both independent reviews were available. Confirmed Claude’s single non-blocking test-coverage nit. The TypeScript and shell filters implement equivalent parameter-grant matching; no functional defects or additional findings were identified.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/command-internal/pg-dump.run.integration.test.ts:70 |
test-coverage |
claude | The new parameter-grant cases exercise only the TypeScript filter, leaving the corresponding shell sed rule without regression coverage. An escaping or matching regression in dumpRoleScript would not fail these tests. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
|
/ai-review |
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews completed with no findings. Reading the changed filters and surrounding code revealed no actionable issues or fundamental conflicts with pending next-branch work. Eight targeted Bash checks passed, covering dry-run expansion, multiline quoting, long settings, and byte preservation. The TypeScript integration suite was not run because dependencies are absent.
Findings
No issues found.
Stats
Claude findings: 0 · Codex findings: 0 · Confirmed: 0 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: manual · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
TL;DR
fixes restoring a
supabase db dump --role-onlyfile aspostgresfailing on a parameter grant to a reserved rolewhats improved/fixed?
supabase db dump --role-onlyalready comments out create, alter and membership grant lines for reserved roles, but parameter grants likeGRANT SET ON PARAMETER "log_min_messages" TO "supabase_realtime_admin";passed throughlinked and local projects whose realtime setup grants this get that line in
roles.sql, so restoring it aspostgresaborted withpermission denied for parameter log_min_messageshow?
a new rule anchored to the start of the line comments out parameter grants to reserved roles, in both the dump script and the in-process filter the local stack uses
grants to other roles and grant text inside role setting values stay as they are
ref: