Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 AI Review
Reviewed both findings against the checked-out code and trusted conventions. Confirmed the missing workflow spans. The stdout workaround was removed, but whether the asynchronous replacement suffers Bun truncation remains uncertain. Exact reproduction was unavailable because dependencies are absent and installed Bun differs from the pinned version.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | packages/api/scripts/dependent-types-check-cache.unit.test.ts:37 |
test-reliability |
claude | Replacing file-backed turbo output with piped stdout may reintroduce Bun/Linux truncation, causing dry-run JSON decoding to fail. |
| 🟡 MINOR | packages/api/scripts/generate.ts:1208 |
observability |
codex | The rewritten generation and download workflows omit the named spans required for changed I/O and millisecond-scale work. |
Stats
Claude findings: 1 · Codex findings: 1 · Confirmed: 1 · Refuted: 0 · Uncertain: 1
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
brings the
packages/apigenerator scripts and their tests under the effect lint, which completes the packagewhats introduced?
packages/api/**download-openapi.tsandgenerate.tsrun as effect programs onFileSystem,HttpClient,ConfigandConsole, with the same requests, console output, generated files and exit codesSUPABASE_API_URLnow reports effect'sUrlErrorChildProcess, and theopenapi.jsonsync test now checks the generator's own serializerref