Skip to content

refactor(cli): move the delegated binary and project link to effect (CLI-2837) - #7300

Open
7ttp wants to merge 4 commits into
developfrom
7ttp/cli-2837-rest-of-command-internal-coverage-prep
Open

7ttp wants to merge 4 commits into
developfrom
7ttp/cli-2837-rest-of-command-internal-coverage-prep

Conversation

@7ttp

@7ttp 7ttp commented Oct 23, 2026

Copy link
Copy Markdown
Member

TL;DR

the delegated binary lookup and the project link writes run through effect, ready for the effect lint

whats improved/fixed?

  • the binary lookup checks its paths through FileSystem and reads its override env var through Config
  • .link.json is written through schema json instead of JSON.stringify
  • the lookup and the permissions help tests run as effects with typed errors

how?

  • the lookup keeps the same search order and the same not found message
  • the link file keeps the same pretty printed bytes

Note

nothing changes for users, the same binary is found and .link.json is exactly the same
these files join the effect lint in the last page of this stack.

ref:

@7ttp 7ttp self-assigned this Oct 23, 2026
@7ttp
7ttp requested a review from a team as a code owner October 23, 2026 12:05

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Confirmed Claude’s single test-hygiene nit, which predates this PR and remains in the rewritten helper. Codex reported no findings, and the adjudication’s static review found no additional regressions. Tests were not run.

Findings

Severity Location Category Sources Claim
⚪ NIT apps/cli/src/command-internal/go-proxy.layer.unit.test.ts:219 test-hygiene claude withMockedHost unmocks a different module from the one it mocks, leaving the CLI_VERSION mock registered after cleanup. This mismatch predates the PR.

Stats

Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

Comment thread apps/cli/src/command-internal/go-proxy.layer.unit.test.ts
@7ttp
7ttp added this pull request to stack #7302 October 23, 2026 12:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant