Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🤖 AI Review
Confirmed Claude’s single test-hygiene nit, which predates this PR and remains in the rewritten helper. Codex reported no findings, and the adjudication’s static review found no additional regressions. Tests were not run.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | apps/cli/src/command-internal/go-proxy.layer.unit.test.ts:219 |
test-hygiene |
claude | withMockedHost unmocks a different module from the one it mocks, leaving the CLI_VERSION mock registered after cleanup. This mismatch predates the PR. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
7ttp
added this pull request to stack #7302
October 23, 2026 12:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
the delegated binary lookup and the project link writes run through effect, ready for the effect lint
whats improved/fixed?
FileSystemand reads its override env var throughConfig.link.jsonis written through schema json instead ofJSON.stringifyhow?
Note
nothing changes for users, the same binary is found and
.link.jsonis exactly the samethese files join the effect lint in the last page of this stack.
ref: