Skip to content

Updates to the Earth-scale example#8340

Merged
ayshih merged 2 commits into
sunpy:mainfrom
ayshih:fix_earth_example
Sep 17, 2025
Merged

Updates to the Earth-scale example#8340
ayshih merged 2 commits into
sunpy:mainfrom
ayshih:fix_earth_example

Conversation

@ayshih
Copy link
Copy Markdown
Member

@ayshih ayshih commented Sep 4, 2025 •
edited
Loading

This PR modifies the Earth-scale example (#8322):

  • A low-resolution Earth image has been added to the repo (sunpy.data.EARTH_IMAGE) so that it does not need to be downloaded for this example.
  • The Earth is now plotted using mesh-based plotting instead of image-based plotting. Depending on the WCS of the underlying map, image-based plotting can sometimes exhibit artifacts that necessitate the use of a clip path, and for some WCSs, even that is not enough. Mesh-based plotting is the most robust approach.
  • The Earth was upside-down (for those of us on the northern hemisphere).

@ayshih ayshih added Examples Related to the Example Gallery. backport 7.0 on-merge: backport to 7.0 labels Sep 4, 2025
@ayshih ayshih force-pushed the fix_earth_example branch 2 times, most recently from e42d712 to 3445dd5 Compare September 4, 2025 15:31
@ayshih ayshih changed the title Switch Earth-scale example to use pcolormesh() Updates to the Earth-scale example Sep 4, 2025
@ayshih ayshih marked this pull request as ready for review September 4, 2025 16:07
Cadair
Cadair approved these changes Sep 17, 2025
View reviewed changes
Comment thread examples/plotting/adding_earth.py Outdated
@ayshih ayshih added the Merge When CI Passes Hit that merge button when it's all green. label Sep 17, 2025
@ayshih ayshih merged commit 56321ab into sunpy:main Sep 17, 2025
34 of 35 checks passed
@ayshih ayshih deleted the fix_earth_example branch September 17, 2025 14:30
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request Sep 17, 2025
@ayshih @meeseeksmachine
Backport PR sunpy#8340: Updates to the Earth-scale example
fad110f
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 17, 2025
Merged
ayshih added a commit that referenced this pull request Sep 17, 2025
@meeseeksmachine @ayshih
Backport PR #8340: Updates to the Earth-scale example (#8350)
a786cb8 
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cadair Cadair Cadair approved these changes

+1 more reviewer

@nabobalis nabobalis nabobalis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport 7.0 on-merge: backport to 7.0 Examples Related to the Example Gallery. Merge When CI Passes Hit that merge button when it's all green.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ayshih @Cadair @nabobalis