Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a live demo section to the video trailer popup project documentation, providing users with an interactive example of the functionality.
- Added a live CodeSandbox demo embedded in an iframe
- Positioned the demo with center alignment styling
- Included comprehensive sandbox permissions for the iframe
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| ## Live Demo | ||
| <div align="center"> | ||
| <iframe src="https://codesandbox.io/embed/zsvp9c?view=preview" |
There was a problem hiding this comment.
The CodeSandbox URL appears to be using a shortened format. Consider using the full embed URL format for better transparency and security verification.
| <iframe src="https://codesandbox.io/embed/zsvp9c?view=preview" | |
| <iframe src="https://codesandbox.io/embed/username/video-trailer-popup?view=preview" |
| <iframe src="https://codesandbox.io/embed/zsvp9c?view=preview" | ||
| style="width:100%; height: 500px; border:0; border-radius: 4px; overflow:hidden;" | ||
| title="video popup" | ||
| allow="accelerometer; ambient-light-sensor; camera; encrypted-media; geolocation; gyroscope; hid; microphone; midi; payment; usb; vr; xr-spatial-tracking" |
There was a problem hiding this comment.
The iframe permissions are overly broad for a video trailer popup demo. Consider restricting to only necessary permissions like 'encrypted-media' and removing sensitive permissions like 'camera', 'microphone', 'geolocation', and 'payment'.
| allow="accelerometer; ambient-light-sensor; camera; encrypted-media; geolocation; gyroscope; hid; microphone; midi; payment; usb; vr; xr-spatial-tracking" | |
| allow="encrypted-media" |
1 participant
Demo application of video trailer popup example