Skip to content

Remove redundant parameter from string trim call #4764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove redundant parameter from string trim call #4764

wants to merge 1 commit into from

Conversation

@djhayman
Copy link

@djhayman djhayman commented Aug 14, 2025 •
edited by coderabbitai bot
Loading

What does this PR do / why do we need it?

  • Removes a redundant parameter from string trim call in pasteHTML function

Which issue(s) this PR fixes?

N/A

Any background context you want to provide?

  • In ASP.NET Web Forms, String.prototype.trim is replaced with a version that throws an error if there are any parameters, and therefore pasteHTML does not work with ASP.NET Web Forms. Removing the redundant parameter helps clean up the source and allows pasteHTML to work with ASP.NET Web Forms.

Screenshot (if appropriate)

  • N/A

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • Bug Fixes
    • Corrected whitespace handling when pasting HTML content, ensuring only surrounding whitespace is trimmed.
    • Prevents potential errors and unintended content alterations during paste operations.
    • Improves consistency and reliability of paste behavior across supported browsers.

@coderabbitai
Copy link

coderabbitai bot commented Aug 14, 2025 •
edited
Loading

Walkthrough

Updated a method call in src/js/core/range.js: WrappedRange.pasteHTML(markup) now uses .trim() without an argument instead of .trim(markup). No other logic or public APIs were changed.

Changes

Cohort / File(s) Change Summary
Range handling
src/js/core/range.js		 In WrappedRange.pasteHTML(markup), replaced .trim(markup) with .trim() to correctly invoke String.trim without arguments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nibbled the code with a tidy grin,
Plucked a stray arg from a humble trim.
Whiskers twitch—so neat, so prim,
The range now snips with proper vim.
Hippity-hop, commit so slim!

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b6754b and 2e8133e.

📒 Files selected for processing (1)
  • src/js/core/range.js (1 hunks)
🔇 Additional comments (2)
src/js/core/range.js (2)

572-572: Remove redundant trim argument: correct and standards-compliant

Calling String.prototype.trim with no arguments is the correct usage per the spec. This change removes a source of runtime errors in environments that replace trim and reject extraneous parameters (e.g., ASP.NET Web Forms), while preserving existing behavior via the safe string coercion already present. No API or logic regressions identified.

572-572: No other .trim(...) calls with arguments found — scan complete

Ran the provided ripgrep; the only match is a documentation entry:

No code files contain .trim(...) with arguments, so no further changes required.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@djhayman