Skip to content

Added missing class .note-popover-content #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added missing class .note-popover-content #4753

wants to merge 2 commits into from

Conversation

@juniwalk
Copy link

@juniwalk juniwalk commented Jun 5, 2025 •
edited
Loading

What does this PR do / why do we need it?

  • AirMode is empty on BS5, because the class .note-popover-content is not included.

Which issue(s) this PR fixes?

Fixes #<issue_number>

Any background context you want to provide?

  • N/A

Screenshot (if appropriate)

  • N/A

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • New Features
    • Expanded popover support to recognize additional content containers, enhancing compatibility with different popover layouts.

@juniwalk
Added missing class .note-popover-content
569814b 
AirMode is empty on BS5, because the class .note-popover-content is not included.
@coderabbitai
Copy link

coderabbitai bot commented Jun 5, 2025 •
edited
Loading

Walkthrough

The change updates the selector in both AirPopover and databasic summernote extension to target elements with either .popover-content or .note-popover-content classes, broadening the elements considered for building buttons within the popover UI.

Changes

File(s) Change Summary
src/js/module/AirPopover.js, public/plugin/databasic/...summernote-ext-databasic.js Updated selector to include .popover-content and .note-popover-content for popover content element lookup.

Poem

In the popover’s gentle air,
More content now can gather there.
With selectors widened, joy expands,
Buttons built by broader hands.
Rabbits cheer this subtle art,
As popovers grow smart—
More places now can play their part! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 569814b and 30f0101.

📒 Files selected for processing (1)
  • public/plugin/databasic/summernote-ext-databasic.js (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • public/plugin/databasic/summernote-ext-databasic.js
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 5, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/js/module/AirPopover.js (1)

67-67: LGTM! Good fix for Bootstrap 5 compatibility.

The change correctly addresses the AirMode display issue with Bootstrap 5 by supporting both .popover-content (Bootstrap 4) and .note-popover-content (Bootstrap 5) selectors. This maintains backward compatibility while fixing the reported issue.

Consider adding a brief comment to document this Bootstrap version compatibility:

// Find content container (supports both Bootstrap 4 and 5)
const $content = this.$popover.find('.popover-content,.note-popover-content');
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b6754b and 569814b.

📒 Files selected for processing (1)
  • src/js/module/AirPopover.js (1 hunks)

@juniwalk
Copy link
Author

juniwalk commented Sep 15, 2025

Hello, can anyone look at this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@juniwalk