Skip to content

Fix *-no-unknown false positives for latest specs by integrating @csstools/css-syntax-patches-for-csstree #8850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romainmenke merged 6 commits into from
Nov 27, 2025
Merged

Fix *-no-unknown false positives for latest specs by integrating @csstools/css-syntax-patches-for-csstree #8850

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
61c1c78
Fix `*-no-unknown` false positives for latest specs by integrating `@…
romainmenke Nov 26, 2025
6954c1c
Create eight-cars-switch.md
romainmenke Nov 26, 2025
27302f5
add test coverage
romainmenke Nov 26, 2025
59b65af
Merge branch 'fix-no-unknown-false-positives-for-latest-specs-by-inte…
romainmenke Nov 26, 2025
afa30d3
remove unreachable code
romainmenke Nov 26, 2025
b092024
Merge branch 'main' into fix-no-unknown-false-positives-for-latest-sp…
romainmenke Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test coverage
  • Loading branch information
@romainmenke
romainmenke committed Nov 26, 2025
commit 27302f504ba3f07834fb7426f4dfd19cada02c1a
148 changes: 148 additions & 0 deletions lib/utils/__tests__/mergeSyntaxDefinitions.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,148 @@
import mergeSyntaxDefinitions from '../mergeSyntaxDefinitions.mjs';

describe('mergeSyntaxDefinitions', () => {
test('merge definitions with undefined arguments', () => {
const a = { syntax: { types: { a: 'a' } } };
const b = {};
const c = {};

expect(mergeSyntaxDefinitions(a.syntax, b.syntax)).toMatchObject(a.syntax);

expect(mergeSyntaxDefinitions(b.syntax, a.syntax)).toMatchObject(a.syntax);

expect(mergeSyntaxDefinitions(b.syntax, c.syntax)).toMatchObject({});
});

describe('atRules', () => {
test('merge definitions where `atrule` is undefined', () => {
const a = { atrules: { a: { prelude: 'a' } } };
const b = {};
const c = {};

expect(mergeSyntaxDefinitions(a, b)).toMatchObject(a);

expect(mergeSyntaxDefinitions(b, a)).toMatchObject(a);

expect(mergeSyntaxDefinitions(b, c)).toMatchObject({});
});

test('merge preludes', () => {
const a = { atrules: { a: { prelude: 'a' } } };
const b = { atrules: { a: { prelude: '| b' } } };

expect(mergeSyntaxDefinitions(a, b)).toMatchObject({ atrules: { a: { prelude: 'a | b' } } });

expect(mergeSyntaxDefinitions(b, a)).toMatchObject({ atrules: { a: { prelude: 'a' } } });
});

test('override preludes', () => {
const a = { atrules: { a: { prelude: 'a' } } };
const b = { atrules: { a: { prelude: 'b' } } };

expect(mergeSyntaxDefinitions(a, b)).toMatchObject({ atrules: { a: { prelude: 'b' } } });
});

test('merge descriptors', () => {
const a = { atrules: { a: { descriptors: { a: 'a' } } } };
const b = { atrules: { a: { descriptors: { a: '| b' } } } };

expect(mergeSyntaxDefinitions(a, b)).toMatchObject({
atrules: { a: { descriptors: { a: 'a | b' } } },
});

expect(mergeSyntaxDefinitions(b, a)).toMatchObject({
atrules: { a: { descriptors: { a: 'a' } } },
});
});

test('override descriptors', () => {
const a = { atrules: { a: { descriptors: { a: 'a' } } } };
const b = { atrules: { a: { descriptors: { a: 'b' } } } };

expect(mergeSyntaxDefinitions(a, b)).toMatchObject({
atrules: { a: { descriptors: { a: 'b' } } },
});
});
});

describe('properties', () => {
test('merge definitions where `properties` is undefined', () => {
const a = { properties: { a: 'a' } };
const b = {};
const c = {};

expect(mergeSyntaxDefinitions(a, b)).toMatchObject(a);

expect(mergeSyntaxDefinitions(b, a)).toMatchObject(a);

expect(mergeSyntaxDefinitions(b, c)).toMatchObject({});
});

test('merge properties', () => {
const a = { properties: { a: 'a' } };
const b = { properties: { a: ' | b' } }; // extra leading space

expect(mergeSyntaxDefinitions(a, b)).toMatchObject({ properties: { a: 'a | b' } });

expect(mergeSyntaxDefinitions(b, a)).toMatchObject({ properties: { a: 'a' } });
});

test('override properties', () => {
const a = { properties: { a: 'a' } };
const b = { properties: { a: 'b' } };

expect(mergeSyntaxDefinitions(a, b)).toMatchObject({ properties: { a: 'b' } });
});
});

describe('types', () => {
test('merge definitions where `types` is undefined', () => {
const a = { types: { a: 'a' } };
const b = {};
const c = {};

expect(mergeSyntaxDefinitions(a, b)).toMatchObject(a);

expect(mergeSyntaxDefinitions(b, a)).toMatchObject(a);

expect(mergeSyntaxDefinitions(b, c)).toMatchObject({});
});

test('merge types', () => {
const a = { types: { a: 'a' } };
const b = { types: { a: ' | b' } }; // extra leading space

expect(mergeSyntaxDefinitions(a, b)).toMatchObject({ types: { a: 'a | b' } });

expect(mergeSyntaxDefinitions(b, a)).toMatchObject({ types: { a: 'a' } });
});

test('override types', () => {
const a = { types: { a: 'a' } };
const b = { types: { a: 'b' } };

expect(mergeSyntaxDefinitions(a, b)).toMatchObject({ types: { a: 'b' } });
});
});

describe('CSS wide keywords', () => {
test('merge definitions where `cssWideKeywords` is undefined', () => {
const a = { cssWideKeywords: [] };
const b = {};
const c = {};

expect(mergeSyntaxDefinitions(a, b)).toMatchObject(a);

expect(mergeSyntaxDefinitions(b, a)).toMatchObject(a);

expect(mergeSyntaxDefinitions(b, c)).toMatchObject({});
});

test('merge keywords', () => {
const a = { cssWideKeywords: ['a', 'b'] };
const b = { cssWideKeywords: ['a', 'c'] };

expect(mergeSyntaxDefinitions(a, b)).toMatchObject({ cssWideKeywords: ['a', 'b', 'c'] });
});
});
});