Fix *-no-unknown false positives for latest specs by integrating @csstools/css-syntax-patches-for-csstree
#8850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…csstools/css-syntax-patches-for-csstree`
🦋 Changeset detectedLatest commit: b092024 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR is packaged and the instant preview is available (b092024). View the demo website. Install it locally: npm i -D https://pkg.pr.new/stylelint@b092024 |
…grating-csstools-css-syntax-patches-for-csstree--adaptable-jaguar-e2fb11b478' of https://github.com/stylelint/stylelint into fix-no-unknown-false-positives-for-latest-specs-by-integrating-csstools-css-syntax-patches-for-csstree--adaptable-jaguar-e2fb11b478
Member
|
This is fantastic, thank you! It's great to see all the issues resolved in the demo.
I've added this to the Prepare 17.0.0 task list. |
romainmenke
commented
Nov 26, 2025
lib/utils/mergeSyntaxDefinitions.mjs
Outdated
Comment on lines
38
to
39
| if (typeof source1 === 'undefined' || typeof source2 === 'undefined') | ||
| return source1 ?? source2 ?? {}; |
Member
Author
There was a problem hiding this comment.
I've built in a lot of checks for undefined. (Maybe these should be extended to cover null?)
My thinking is that we want to be really forgiving in these objects and configs and allow authors to pass only those definitions they want to override.
If you see ways we can improve this code, feedback is welcome :)
Member
Author
There was a problem hiding this comment.
This specific instance was unreachable and could be removed, but the pattern repeats itself a few times in this file :)
Member
There was a problem hiding this comment.
My thinking is that we want to be really forgiving in these objects and configs and allow authors to pass only those definitions they want to override.
That sounds appropriate to me.
Member
Author
|
I'll wait a bit before merging in case other maintainers have feedback |
…ecs-by-integrating-csstools-css-syntax-patches-for-csstree--adaptable-jaguar-e2fb11b478
romainmenke
deleted the
fix-no-unknown-false-positives-for-latest-specs-by-integrating-csstools-css-syntax-patches-for-csstree--adaptable-jaguar-e2fb11b478
branch
Mouvedia
reviewed
Nov 27, 2025
| }, | ||
| "dependencies": { | ||
| "@csstools/css-parser-algorithms": "^3.0.5", | ||
| "@csstools/css-syntax-patches-for-csstree": "^1.0.19", |
Member
There was a problem hiding this comment.
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 29, 2025
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.26.0 | 16.26.1 | ## [v16.26.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16261---2025-11-28) It fixes numerous false positive bugs, including many in the `declaration-property-value-no-unknown` rule for the latest CSS specifications. - Fixed: `*-no-unknown` false positives for latest specs by integrating `@csstools/css-syntax-patches-for-csstree` ([#8850](stylelint/stylelint#8850)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `at-rule-no-unknown` false positives for `@function` ([#8851](stylelint/stylelint#8851)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `declaration-property-value-no-unknown` false positives for `attr()`, `if()` and custom functions ([#8853](stylelint/stylelint#8853)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `function-url-quotes` false positives when URLs require quoting ([#8804](stylelint/stylelint#8804)) ([@taearls](https://github.com/taearls)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::scroll-button()` ([#8856](stylelint/stylelint#8856)) ([@Mouvedia](https://github.com/Mouvedia)).
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 30, 2025
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.26.0 | 16.26.1 | ## [v16.26.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16261---2025-11-28) It fixes numerous false positive bugs, including many in the `declaration-property-value-no-unknown` rule for the latest CSS specifications. - Fixed: `*-no-unknown` false positives for latest specs by integrating `@csstools/css-syntax-patches-for-csstree` ([#8850](stylelint/stylelint#8850)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `at-rule-no-unknown` false positives for `@function` ([#8851](stylelint/stylelint#8851)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `declaration-property-value-no-unknown` false positives for `attr()`, `if()` and custom functions ([#8853](stylelint/stylelint#8853)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `function-url-quotes` false positives when URLs require quoting ([#8804](stylelint/stylelint#8804)) ([@taearls](https://github.com/taearls)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::scroll-button()` ([#8856](stylelint/stylelint#8856)) ([@Mouvedia](https://github.com/Mouvedia)).
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 1, 2025
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.26.0 | 16.26.1 | ## [v16.26.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16261---2025-11-28) It fixes numerous false positive bugs, including many in the `declaration-property-value-no-unknown` rule for the latest CSS specifications. - Fixed: `*-no-unknown` false positives for latest specs by integrating `@csstools/css-syntax-patches-for-csstree` ([#8850](stylelint/stylelint#8850)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `at-rule-no-unknown` false positives for `@function` ([#8851](stylelint/stylelint#8851)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `declaration-property-value-no-unknown` false positives for `attr()`, `if()` and custom functions ([#8853](stylelint/stylelint#8853)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `function-url-quotes` false positives when URLs require quoting ([#8804](stylelint/stylelint#8804)) ([@taearls](https://github.com/taearls)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::scroll-button()` ([#8856](stylelint/stylelint#8856)) ([@Mouvedia](https://github.com/Mouvedia)).
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 2, 2025
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.26.0 | 16.26.1 | ## [v16.26.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16261---2025-11-28) It fixes numerous false positive bugs, including many in the `declaration-property-value-no-unknown` rule for the latest CSS specifications. - Fixed: `*-no-unknown` false positives for latest specs by integrating `@csstools/css-syntax-patches-for-csstree` ([#8850](stylelint/stylelint#8850)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `at-rule-no-unknown` false positives for `@function` ([#8851](stylelint/stylelint#8851)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `declaration-property-value-no-unknown` false positives for `attr()`, `if()` and custom functions ([#8853](stylelint/stylelint#8853)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `function-url-quotes` false positives when URLs require quoting ([#8804](stylelint/stylelint#8804)) ([@taearls](https://github.com/taearls)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::scroll-button()` ([#8856](stylelint/stylelint#8856)) ([@Mouvedia](https://github.com/Mouvedia)).
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 4, 2025
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.26.0 | 16.26.1 | ## [v16.26.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16261---2025-11-28) It fixes numerous false positive bugs, including many in the `declaration-property-value-no-unknown` rule for the latest CSS specifications. - Fixed: `*-no-unknown` false positives for latest specs by integrating `@csstools/css-syntax-patches-for-csstree` ([#8850](stylelint/stylelint#8850)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `at-rule-no-unknown` false positives for `@function` ([#8851](stylelint/stylelint#8851)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `declaration-property-value-no-unknown` false positives for `attr()`, `if()` and custom functions ([#8853](stylelint/stylelint#8853)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `function-url-quotes` false positives when URLs require quoting ([#8804](stylelint/stylelint#8804)) ([@taearls](https://github.com/taearls)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::scroll-button()` ([#8856](stylelint/stylelint#8856)) ([@Mouvedia](https://github.com/Mouvedia)).
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 4, 2025
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.26.0 | 16.26.1 | ## [v16.26.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16261---2025-11-28) It fixes numerous false positive bugs, including many in the `declaration-property-value-no-unknown` rule for the latest CSS specifications. - Fixed: `*-no-unknown` false positives for latest specs by integrating `@csstools/css-syntax-patches-for-csstree` ([#8850](stylelint/stylelint#8850)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `at-rule-no-unknown` false positives for `@function` ([#8851](stylelint/stylelint#8851)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `declaration-property-value-no-unknown` false positives for `attr()`, `if()` and custom functions ([#8853](stylelint/stylelint#8853)) ([@jeddy3](https://github.com/jeddy3)). - Fixed: `function-url-quotes` false positives when URLs require quoting ([#8804](stylelint/stylelint#8804)) ([@taearls](https://github.com/taearls)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::scroll-button()` ([#8856](stylelint/stylelint#8856)) ([@Mouvedia](https://github.com/Mouvedia)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*-no-unknownfalse positives for latest specs by integrating@csstools/css-syntax-patches-for-csstree#8100declaration-property-value-no-unknownfalse positives forcalc-sizeandshapefunctions #8320declaration-property-value-no-unknownfalse positives for color function relative syntax #8347declaration-property-value-no-unknownfalse positives forlinear()#8379declaration-property-value-no-unknownfalse positives forscroll-stateoncontainer-type#8607declaration-property-value-no-unknownfalse positives foranchor()ofinset#8609declaration-property-value-no-unknownfalse positives forgradient(in color space)ofbackground#8610declaration-property-value-no-unknownfalse positives forbase-selectofappearance#8778JSDOM recently adopted
@csstools/css-syntax-patches-for-csstreewhich made me less reluctant to integrate it directly here. It seems to work well there and nothing surprising or alarming surfaced.The merging of various configs wasn't entirely correct before.
CSSTree supports appending definitions by leading with a pipe symbol
|.While our code always did overrides with the spread operator.
This matters when we are combining multiple sources (syntax patches from csstools, language options, rule config)