Skip to content

Fix no-invalid-position-declaration false positives for embedded styles #8701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeddy3 merged 11 commits into from
Aug 7, 2025
Merged

Fix no-invalid-position-declaration false positives for embedded styles #8701

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d04247d
fix `no-invalid-position-declaration` false positives for embedded st…
sw1tch3roo Aug 1, 2025
556584f
Add accept test case for `<style>--custom-property: blue;</style>`
sw1tch3roo Aug 2, 2025
1da579e
changes after review
sw1tch3roo Aug 3, 2025
a623517
Merge branch 'main' into fix/no-invalid-position-declaration-in-style…
sw1tch3roo Aug 4, 2025
4a9e6dc
changes after review
sw1tch3roo Aug 4, 2025
e947322
Restore original `isInDocument` to handle CSS-in-JS ASTs correctly
sw1tch3roo Aug 4, 2025
80a203a
add test for `isInDocument` util
sw1tch3roo Aug 4, 2025
5379f6a
Merge branch 'main' into fix/no-invalid-position-declaration-in-style…
sw1tch3roo Aug 5, 2025
48c4bd9
Merge branch 'main' into fix/no-invalid-position-declaration-in-style…
sw1tch3roo Aug 5, 2025
ce24f1c
add a comment that describes the code relies on the unofficial docume…
sw1tch3roo Aug 5, 2025
fc67a96
add `instanceof Node` to document node
sw1tch3roo Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add instanceof Node to document node
  • Loading branch information
@sw1tch3roo
sw1tch3roo committed Aug 6, 2025
commit fc67a960c2b6c5e44fa6049ad108fd86561bd97a
9 changes: 3 additions & 6 deletions lib/utils/isInDocument.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 4 additions & 6 deletions lib/utils/isInDocument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { Node } from 'postcss';

import { isDocument } from './typeGuards.mjs';

/**
* @param {import('postcss').Node} node
* @param {Node} node
* @returns {boolean}
*/
export default function isInDocument(node) {
Expand All @@ -11,11 +13,7 @@ export default function isInDocument(node) {
if (isDocument(current)) return true;

// Check for unofficial 'document' property from parsers like postcss-html
if (
'document' in current &&
current.document &&
isDocument(/** @type {import('postcss').Document} */ (current.document))
)
if ('document' in current && current.document instanceof Node && isDocument(current.document))
return true;

if (!current.parent) break;
Expand Down
Loading