Skip to content

Fix no-invalid-position-declaration false positives for embedded styles #8701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeddy3 merged 11 commits into from
Aug 7, 2025
Merged

Fix no-invalid-position-declaration false positives for embedded styles #8701

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d04247d
fix `no-invalid-position-declaration` false positives for embedded st…
sw1tch3roo Aug 1, 2025
556584f
Add accept test case for `<style>--custom-property: blue;</style>`
sw1tch3roo Aug 2, 2025
1da579e
changes after review
sw1tch3roo Aug 3, 2025
a623517
Merge branch 'main' into fix/no-invalid-position-declaration-in-style…
sw1tch3roo Aug 4, 2025
4a9e6dc
changes after review
sw1tch3roo Aug 4, 2025
e947322
Restore original `isInDocument` to handle CSS-in-JS ASTs correctly
sw1tch3roo Aug 4, 2025
80a203a
add test for `isInDocument` util
sw1tch3roo Aug 4, 2025
5379f6a
Merge branch 'main' into fix/no-invalid-position-declaration-in-style…
sw1tch3roo Aug 5, 2025
48c4bd9
Merge branch 'main' into fix/no-invalid-position-declaration-in-style…
sw1tch3roo Aug 5, 2025
ce24f1c
add a comment that describes the code relies on the unofficial docume…
sw1tch3roo Aug 5, 2025
fc67a96
add `instanceof Node` to document node
sw1tch3roo Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add accept test case for <style>--custom-property: blue;</style>
  • Loading branch information
@sw1tch3roo
sw1tch3roo committed Aug 2, 2025
commit 556584fb582fe13e48514c66ea3c1bf9796f200f
4 changes: 4 additions & 0 deletions lib/rules/no-invalid-position-declaration/__tests__/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,10 @@ testRule({
code: '<span style="font-size: 14px; margin: 10px;"></span>',
description: 'HTML style attribute with multiple properties',
},
{
code: '<style>--custom-property: blue;</style>',
description: 'HTML style element with custom property',
},
],
});

Expand Down
Loading