Add `rule-nesting-at-rule-required-list` #8680

sw1tch3roo · 2025-07-22T19:21:46Z

Which issue, if any, is this issue related to?

Closes #8481.

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

changeset-bot · 2025-07-22T19:21:51Z

🦋 Changeset detected

Latest commit: 6260d46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…quired-list

lib/rules/declaration-block-nesting-at-rule-required-list/README.md

Mouvedia

Thanks for the contribution.
I just read the README and found one typo, could you fix it?

lib/rules/declaration-block-nesting-at-rule-required-list/README.md

lib/rules/declaration-block-nesting-at-rule-required-list/index.mjs

jeddy3

@sw1tch3roo Thank you for the PR. You're on fire with all these contributions!

I've proposed a slight shift in the scope and behaviour of the rule. These things often only become apparent once we start the implementation.

lib/rules/declaration-block-nesting-at-rule-required-list/__tests__/index.mjs

sw1tch3roo · 2025-07-23T18:18:03Z

I've made all the changes you described, and in theory all the test cases are covered. I'll be waiting for the review =)

resolved

…quired-list

jeddy3

Thanks for making the changes. I think it's shaping up nicely.

I've requested some minor changes to the docs, tests and code style. Otherwise, I think it looks good.

lib/rules/rule-nesting-at-rule-required-list/index.mjs

lib/rules/rule-nesting-at-rule-required-list/README.md

lib/rules/rule-nesting-at-rule-required-list/__tests__/index.mjs

lib/rules/rule-nesting-at-rule-required-list/index.mjs

docs/user-guide/rules.md

…date README.md

sw1tch3roo · 2025-07-24T17:49:09Z

@jeddy3 ty for your thorough review 💌

…quired-list

jeddy3

Thanks for making the changes.

Just two more minor tweaks from me, then LGTM.

lib/rules/rule-nesting-at-rule-required-list/README.md

lib/rules/rule-nesting-at-rule-required-list/index.mjs

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

github-actions · 2025-07-25T09:38:22Z

This PR is packaged and the instant preview is available (6260d46). View the demo website.

Install it locally:

npm i -D https://pkg.pr.new/stylelint@6260d46

…quired-list

jeddy3 · 2025-07-25T10:42:53Z

Thanks for making the changes. Let's build the CJS files and push to fix the failing test.

sw1tch3roo · 2025-07-25T10:51:03Z

I completely forgot about it, wait a second =)

jeddy3

I forgot about the type guard and standard syntax utils 😅

Let's use them.

lib/rules/rule-nesting-at-rule-required-list/index.mjs

…quired-list

jeddy3

Thank you for making the changes.

One change got overlooked, which I've highlighted.

lib/rules/rule-nesting-at-rule-required-list/README.md

…quired-list

jeddy3

LGTM, thank you

…quired-list

resolved

types/stylelint/index.d.ts

…quired-list

sw1tch3roo · 2025-08-11T15:23:49Z

@ybiquitous Hi! Could you check the changes when you have some free time?

ybiquitous

@sw1tch3roo Sorry for my late response! Looks great, thank you 👍🏼

@sw1tch3roo

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.23.1 | 16.24.0 | ## [v16.24.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16240---2025-09-07) It adds 1 new rule, adds 1 option to a rule and fixes 2 bugs. - Added: `rule-nesting-at-rule-required-list` rule ([#8680](stylelint/stylelint#8680)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `ignoreAtRules: []` to `nesting-selector-no-missing-scoping-root` ([#8743](stylelint/stylelint#8743)) ([@karlhorky](https://github.com/karlhorky)). - Fixed: `function-no-unknown` false positives for `contrast-color()` and `sibling-*()` ([#8729](stylelint/stylelint#8729)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:heading` ([#8749](stylelint/stylelint#8749)) ([@Mouvedia](https://github.com/Mouvedia)).

@sw1tch3roo

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.23.1 | 16.24.0 | ## [v16.24.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16240---2025-09-07) It adds 1 new rule, adds 1 option to a rule and fixes 2 bugs. - Added: `rule-nesting-at-rule-required-list` rule ([#8680](stylelint/stylelint#8680)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `ignoreAtRules: []` to `nesting-selector-no-missing-scoping-root` ([#8743](stylelint/stylelint#8743)) ([@karlhorky](https://github.com/karlhorky)). - Fixed: `function-no-unknown` false positives for `contrast-color()` and `sibling-*()` ([#8729](stylelint/stylelint#8729)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:heading` ([#8749](stylelint/stylelint#8749)) ([@Mouvedia](https://github.com/Mouvedia)).

add declaration-block-nesting-at-rule-required-list

e649efa

sw1tch3roo and others added 2 commits July 22, 2025 22:21

Merge branch 'main' into feature/declaration-block-nesting-at-rule-re…

d51f557

…quired-list

fix the type in index.d.ts

3c04e94

Mouvedia reviewed Jul 22, 2025

View reviewed changes

lib/rules/declaration-block-nesting-at-rule-required-list/README.md Outdated Show resolved Hide resolved

Mouvedia previously requested changes Jul 22, 2025

View reviewed changes

Mouvedia changed the title ~~add declaration-block-nesting-at-rule-required-list~~ Add declaration-block-nesting-at-rule-required-list Jul 22, 2025

jeddy3 requested changes Jul 23, 2025

View reviewed changes

lib/rules/declaration-block-nesting-at-rule-required-list/__tests__/index.mjs Outdated Show resolved Hide resolved

Refactor rule to check entire rules instead of individual declarations

3fe8df7

sw1tch3roo changed the title ~~Add declaration-block-nesting-at-rule-required-list~~ Add rule-nesting-at-rule-required-list Jul 23, 2025

sw1tch3roo requested a review from jeddy3 July 24, 2025 08:14

Merge branch 'main' into feature/declaration-block-nesting-at-rule-re…

016b16e

…quired-list

jeddy3 requested changes Jul 24, 2025

View reviewed changes

changes after review: change code style, delete unnecessary tests, up…

cbade06

…date README.md

Merge branch 'main' into feature/declaration-block-nesting-at-rule-re…

52c7654

…quired-list

sw1tch3roo requested a review from jeddy3 July 24, 2025 18:36

jeddy3 requested changes Jul 24, 2025

View reviewed changes

lib/rules/rule-nesting-at-rule-required-list/README.md Outdated Show resolved Hide resolved

lib/rules/rule-nesting-at-rule-required-list/index.mjs Outdated Show resolved Hide resolved

Mouvedia reviewed Jul 24, 2025

View reviewed changes

lib/rules/rule-nesting-at-rule-required-list/index.mjs Outdated Show resolved Hide resolved

suggestions from code review

e048d14

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

Merge branch 'main' into feature/declaration-block-nesting-at-rule-re…

18b7ec7

…quired-list

build cjs file

2bdb301

jeddy3 requested changes Jul 25, 2025

View reviewed changes

lib/rules/rule-nesting-at-rule-required-list/index.mjs Outdated Show resolved Hide resolved

lib/rules/rule-nesting-at-rule-required-list/index.mjs Outdated Show resolved Hide resolved

lib/rules/rule-nesting-at-rule-required-list/index.mjs Show resolved Hide resolved

jeddy3 mentioned this pull request Jul 25, 2025

Document using type guards when writing rules #8686

Merged

use typeGuards utils

db6523f

enhance the expected messages

d90f473

sw1tch3roo requested a review from ybiquitous July 28, 2025 16:35

Merge branch 'main' into feature/declaration-block-nesting-at-rule-re…

fb24ded

…quired-list

jeddy3 requested changes Jul 28, 2025

View reviewed changes

lib/rules/rule-nesting-at-rule-required-list/README.md Outdated Show resolved Hide resolved

sw1tch3roo requested a review from jeddy3 July 28, 2025 17:30

This comment was marked as resolved.

Sign in to view

change the examples in README.md

e79ff39

sw1tch3roo force-pushed the feature/declaration-block-nesting-at-rule-required-list branch from 58864ff to e79ff39 Compare July 28, 2025 20:08

Merge branch 'main' into feature/declaration-block-nesting-at-rule-re…

9f765c3

…quired-list

jeddy3 approved these changes Jul 29, 2025

View reviewed changes

Merge branch 'main' into feature/declaration-block-nesting-at-rule-re…

fa64d61

…quired-list

Mouvedia reviewed Aug 2, 2025

View reviewed changes

types/stylelint/index.d.ts Outdated Show resolved Hide resolved

sw1tch3roo force-pushed the feature/declaration-block-nesting-at-rule-required-list branch from 5538e06 to 058ccfa Compare August 2, 2025 14:24

fix expected message type in d.ts declaration

dd2a7ff

sw1tch3roo force-pushed the feature/declaration-block-nesting-at-rule-required-list branch from 058ccfa to dd2a7ff Compare August 2, 2025 14:31

Mouvedia reviewed Aug 2, 2025

View reviewed changes

types/stylelint/index.d.ts Outdated Show resolved Hide resolved

reuse the type of args

554ecd6

sw1tch3roo force-pushed the feature/declaration-block-nesting-at-rule-required-list branch from 0832171 to 554ecd6 Compare August 2, 2025 17:37

Mouvedia reviewed Aug 2, 2025

View reviewed changes

types/stylelint/index.d.ts Outdated Show resolved Hide resolved

change expected message type in d.ts

5dca318

Mouvedia reviewed Aug 2, 2025

View reviewed changes

types/stylelint/index.d.ts Show resolved Hide resolved

sw1tch3roo added 3 commits August 4, 2025 12:11

Merge branch 'main' into feature/declaration-block-nesting-at-rule-re…

c0c5591

…quired-list

Merge branch 'main' into feature/declaration-block-nesting-at-rule-re…

f4000e8

…quired-list

Merge branch 'main' into feature/declaration-block-nesting-at-rule-re…

6260d46

…quired-list

ybiquitous approved these changes Aug 12, 2025

View reviewed changes

ybiquitous merged commit 75dc62c into stylelint:main Aug 12, 2025
17 checks passed

Uh oh!

Add rule-nesting-at-rule-required-list #8680

Add rule-nesting-at-rule-required-list #8680

Uh oh!

Conversation

sw1tch3roo commented Jul 22, 2025

Uh oh!

changeset-bot bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Mouvedia left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sw1tch3roo commented Jul 23, 2025

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sw1tch3roo commented Jul 24, 2025

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeddy3 commented Jul 25, 2025

Uh oh!

sw1tch3roo commented Jul 25, 2025

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sw1tch3roo commented Aug 11, 2025

Uh oh!

ybiquitous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Add `rule-nesting-at-rule-required-list` #8680

Add `rule-nesting-at-rule-required-list` #8680

changeset-bot bot commented Jul 22, 2025 •

edited

Loading

Mouvedia left a comment •

edited

Loading

github-actions bot commented Jul 25, 2025 •

edited

Loading