Add `no-invalid-position-declaration` #8669

sw1tch3roo · 2025-07-13T17:53:14Z

Is there anything in the PR that needs further
explanation?

No, it's self-explanatory. This PR implements the no-invalid-position-declaration rule as specified in the issue, which disallows declarations at the root level outside of rules and at-rules. The implementation follows the existing no-invalid-position-at-import-rule as a blueprint and includes comprehensive tests covering both custom properties and regular CSS properties =)

changeset-bot · 2025-07-13T17:53:17Z

🦋 Changeset detected

Latest commit: 81e383b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jeddy3

@sw1tch3roo Thank you for working on this PR. It's looking good so far!

I've requested an initial round of changes. The main one is catching false negatives for declarations inside at-rules that only accept <rule-list>, such as unnested @media and @supports.

lib/rules/no-invalid-position-declaration/README.md

lib/rules/no-invalid-position-declaration/__tests__/index.mjs

lib/rules/no-invalid-position-declaration/README.md

lib/rules/no-invalid-position-declaration/__tests__/index.mjs

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

…ch declarations in at-rules that only accept <rule-list>, apply suggestions from code review

github-actions · 2025-07-15T08:34:17Z

This PR is packaged and the instant preview is available (81e383b). View the demo website.

Install it locally:

npm i -D https://pkg.pr.new/stylelint@81e383b

lib/rules/no-invalid-position-declaration/__tests__/index.mjs

…est cases

jeddy3

Thanks for making the changes. It's shaping up nicely.

I've added some more suggestions.

(It typically takes a few go-arounds to review a new rule, especially one we'll be adding to our recommended config and rolling out to most of our users.)

lib/rules/no-invalid-position-declaration/README.md

lib/rules/no-invalid-position-declaration/__tests__/index.mjs

lib/rules/no-invalid-position-declaration/index.mjs

lib/rules/no-invalid-position-declaration/README.md

lib/rules/no-invalid-position-declaration/__tests__/index.mjs

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

…ion' rule

jeddy3

Thank you for making the further changes. I think it's almost there.

I've requested a couple more changes related to the:

behaviour of @apply
matching our conventions throughout the tests
refactoring the code to follow our typical returning early pattern

lib/rules/no-invalid-position-declaration/README.md

lib/rules/no-invalid-position-declaration/index.mjs

lib/rules/no-invalid-position-declaration/__tests__/index.mjs

lib/rules/no-invalid-position-declaration/index.mjs

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

sw1tch3roo · 2025-07-15T17:32:35Z

@jeddy3 thanks again for the thorough review, it's very comfortable to study your repository and the rules, I'm very happy to contribute =)

lib/rules/no-invalid-position-declaration/index.mjs

jeddy3

It's looking great, thanks.

I've made one last request to help out SCSS users.

(You'll need to pull and rebuild as I pushed a suggestion commit to fix the import order.)

lib/rules/no-invalid-position-declaration/index.mjs

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

sw1tch3roo · 2025-07-16T07:43:47Z

It's looking great, thanks.

I've made one last request to help out SCSS users.

(You'll need to pull and rebuild as I pushed a suggestion commit to fix the import order.)

Done!

jeddy3

Nicely done. LGTM, thank you.

It's a useful rule that'll catch the common mistakes of:

custom props outside of a rule
declarations inside at-rules but not inside a rule

We typically wait for two reviews for new rules, especially as we'll turn this rule on in our recommended config.

lib/rules/no-invalid-position-declaration/README.md

lib/rules/no-invalid-position-declaration/index.mjs

lib/rules/no-invalid-position-declaration/__tests__/index.mjs

sw1tch3roo · 2025-07-17T14:27:37Z

@Mouvedia do you have any other thoughts on the PR?

Mouvedia · 2025-07-17T14:43:13Z

@Mouvedia do you have any other thoughts on the PR?

I think the description and the message could be better.
i.e. rewording/rephrasing
e.g. Disallow invalid positions for declarations

I don't have time to test it thoroughly; maybe there are edge cases because the check for at-rules is not recursive, I dunno.
The test coverage seems decent.
It's looking good for a first contribution.

This rule will probably be part of the 16.23.0 release.
i.e. things go slowly in the summer

sw1tch3roo · 2025-07-23T17:39:54Z

@jeddy3 @ybiquitous @romainmenke Hi! What do you think about the description and the message of this rule? (check the above)

jeddy3 · 2025-07-24T13:45:18Z

Let's keep it as it is for now, as it's consistent with the other invalid-position rule. We can open a follow-up issue to review our rule messages and descriptions as a whole, as they could be written better.

ybiquitous

LGTM, thank you. 😄

lib/rules/no-invalid-position-declaration/index.mjs

@sw1tch3roo

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.20.0 | 16.23.0 | ## [v16.23.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16230---2025-07-29) It adds 5 new rules, 1 option to a rule and fixes 3 bugs. We've turned on the new rules in our [standard config](https://www.npmjs.com/package/stylelint-config-standard). - Added: `block-no-redundant-nested-style-rules` rule ([#8684](stylelint/stylelint#8684)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `media-type-no-deprecated` rule ([#8668](stylelint/stylelint#8668)) ([@immitsu](https://github.com/immitsu)). - Added: `nesting-selector-no-missing-scoping-root` rule ([#8674](stylelint/stylelint#8674)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `no-invalid-position-declaration` rule ([#8669](stylelint/stylelint#8669)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `property-no-deprecated` rule ([#8682](stylelint/stylelint#8682)) ([@immitsu](https://github.com/immitsu)). - Added: `except: ["exact-value"]` to `media-feature-range-notation` ([#8675](stylelint/stylelint#8675)) ([@immitsu](https://github.com/immitsu)). - Fixed: `declaration-block-no-duplicate-properties` false negatives for named colors with `ignore: ['consecutive-duplicates-with-different-syntaxes']` ([#8665](stylelint/stylelint#8665)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Fixed: `function-no-unknown` false positives ([#8677](stylelint/stylelint#8677)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `no-irregular-whitespace` false positives for strings ([#8667](stylelint/stylelint#8667)) ([@immitsu](https://github.com/immitsu)). ## [v16.22.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16220---2025-07-18) It adds 3 rule features and fixes 2 bugs. - Added: `messageArgs` to `color-named` ([#8663](stylelint/stylelint#8663)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `messageArgs` to `declaration-property-value-keyword-no-deprecated` ([#8654](stylelint/stylelint#8654)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `no-descending-specificity` report message includes line number of the anchoring selector ([#8666](stylelint/stylelint#8666)) ([@immitsu](https://github.com/immitsu)). - Fixed: `at-rule-no-deprecated` false positives for `@apply` ([#8630](stylelint/stylelint#8630)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `lightness-notation` crash with `"number"` option and single-digit percentage ([#8661](stylelint/stylelint#8661)) ([@ybiquitous](https://github.com/ybiquitous)). ## [v16.21.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16211---2025-07-03) It fixes 3 bugs. - Fixed: unexpected change of syntax in computed `EditInfo` ([#8638](stylelint/stylelint#8638)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `function-linear-gradient-no-nonstandard-direction` false positives for CSS variables' names containing a direction substring ([#8643](stylelint/stylelint#8643)) ([@Solomon-mithra](https://github.com/Solomon-mithra)). - Fixed: `media-feature-range-notation` autofix for exact values ([#8651](stylelint/stylelint#8651)) ([@romainmenke](https://github.com/romainmenke)). ## [v16.21.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16210---2025-06-19) It rounds out the `message` secondary option and marks it as stable, adds 1 new option to a rule, and fixes 4 bugs. - Added: non-experimental support for functional `message` secondary option ([#8595](stylelint/stylelint#8595)) ([@ybiquitous](https://github.com/ybiquitous)). - Added: `ignore: ["after-custom-property"]` to `custom-property-empty-line-before` ([#8627](stylelint/stylelint#8627)) ([@imkesin](https://github.com/imkesin)). - Fixed: `cache` configuration property not being respected ([#8599](stylelint/stylelint#8599)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `fastest-levenshtein` import when bundling ([#8621](stylelint/stylelint#8621)) ([@onigoetz](https://github.com/onigoetz)). - Fixed: `named-grid-areas-no-invalid` false positives for interpolated grid-template-areas in CSS-in-JS ([#8606](stylelint/stylelint#8606)) ([@shahana308](https://github.com/shahana308)). - Fixed: `selector-pseudo-*-no-unknown` false positives for the missing form control styling selectors ([#8623](stylelint/stylelint#8623)) ([@tyrann0us](https://github.com/tyrann0us)).

@sw1tch3roo

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.20.0 | 16.23.0 | ## [v16.23.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16230---2025-07-29) It adds 5 new rules, 1 option to a rule and fixes 3 bugs. We've turned on the new rules in our [standard config](https://www.npmjs.com/package/stylelint-config-standard). - Added: `block-no-redundant-nested-style-rules` rule ([#8684](stylelint/stylelint#8684)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `media-type-no-deprecated` rule ([#8668](stylelint/stylelint#8668)) ([@immitsu](https://github.com/immitsu)). - Added: `nesting-selector-no-missing-scoping-root` rule ([#8674](stylelint/stylelint#8674)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `no-invalid-position-declaration` rule ([#8669](stylelint/stylelint#8669)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `property-no-deprecated` rule ([#8682](stylelint/stylelint#8682)) ([@immitsu](https://github.com/immitsu)). - Added: `except: ["exact-value"]` to `media-feature-range-notation` ([#8675](stylelint/stylelint#8675)) ([@immitsu](https://github.com/immitsu)). - Fixed: `declaration-block-no-duplicate-properties` false negatives for named colors with `ignore: ['consecutive-duplicates-with-different-syntaxes']` ([#8665](stylelint/stylelint#8665)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Fixed: `function-no-unknown` false positives ([#8677](stylelint/stylelint#8677)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `no-irregular-whitespace` false positives for strings ([#8667](stylelint/stylelint#8667)) ([@immitsu](https://github.com/immitsu)). ## [v16.22.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16220---2025-07-18) It adds 3 rule features and fixes 2 bugs. - Added: `messageArgs` to `color-named` ([#8663](stylelint/stylelint#8663)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `messageArgs` to `declaration-property-value-keyword-no-deprecated` ([#8654](stylelint/stylelint#8654)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `no-descending-specificity` report message includes line number of the anchoring selector ([#8666](stylelint/stylelint#8666)) ([@immitsu](https://github.com/immitsu)). - Fixed: `at-rule-no-deprecated` false positives for `@apply` ([#8630](stylelint/stylelint#8630)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `lightness-notation` crash with `"number"` option and single-digit percentage ([#8661](stylelint/stylelint#8661)) ([@ybiquitous](https://github.com/ybiquitous)). ## [v16.21.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16211---2025-07-03) It fixes 3 bugs. - Fixed: unexpected change of syntax in computed `EditInfo` ([#8638](stylelint/stylelint#8638)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `function-linear-gradient-no-nonstandard-direction` false positives for CSS variables' names containing a direction substring ([#8643](stylelint/stylelint#8643)) ([@Solomon-mithra](https://github.com/Solomon-mithra)). - Fixed: `media-feature-range-notation` autofix for exact values ([#8651](stylelint/stylelint#8651)) ([@romainmenke](https://github.com/romainmenke)). ## [v16.21.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16210---2025-06-19) It rounds out the `message` secondary option and marks it as stable, adds 1 new option to a rule, and fixes 4 bugs. - Added: non-experimental support for functional `message` secondary option ([#8595](stylelint/stylelint#8595)) ([@ybiquitous](https://github.com/ybiquitous)). - Added: `ignore: ["after-custom-property"]` to `custom-property-empty-line-before` ([#8627](stylelint/stylelint#8627)) ([@imkesin](https://github.com/imkesin)). - Fixed: `cache` configuration property not being respected ([#8599](stylelint/stylelint#8599)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `fastest-levenshtein` import when bundling ([#8621](stylelint/stylelint#8621)) ([@onigoetz](https://github.com/onigoetz)). - Fixed: `named-grid-areas-no-invalid` false positives for interpolated grid-template-areas in CSS-in-JS ([#8606](stylelint/stylelint#8606)) ([@shahana308](https://github.com/shahana308)). - Fixed: `selector-pseudo-*-no-unknown` false positives for the missing form control styling selectors ([#8623](stylelint/stylelint#8623)) ([@tyrann0us](https://github.com/tyrann0us)).

@sw1tch3roo

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.20.0 | 16.23.0 | ## [v16.23.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16230---2025-07-29) It adds 5 new rules, 1 option to a rule and fixes 3 bugs. We've turned on the new rules in our [standard config](https://www.npmjs.com/package/stylelint-config-standard). - Added: `block-no-redundant-nested-style-rules` rule ([#8684](stylelint/stylelint#8684)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `media-type-no-deprecated` rule ([#8668](stylelint/stylelint#8668)) ([@immitsu](https://github.com/immitsu)). - Added: `nesting-selector-no-missing-scoping-root` rule ([#8674](stylelint/stylelint#8674)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `no-invalid-position-declaration` rule ([#8669](stylelint/stylelint#8669)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `property-no-deprecated` rule ([#8682](stylelint/stylelint#8682)) ([@immitsu](https://github.com/immitsu)). - Added: `except: ["exact-value"]` to `media-feature-range-notation` ([#8675](stylelint/stylelint#8675)) ([@immitsu](https://github.com/immitsu)). - Fixed: `declaration-block-no-duplicate-properties` false negatives for named colors with `ignore: ['consecutive-duplicates-with-different-syntaxes']` ([#8665](stylelint/stylelint#8665)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Fixed: `function-no-unknown` false positives ([#8677](stylelint/stylelint#8677)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `no-irregular-whitespace` false positives for strings ([#8667](stylelint/stylelint#8667)) ([@immitsu](https://github.com/immitsu)). ## [v16.22.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16220---2025-07-18) It adds 3 rule features and fixes 2 bugs. - Added: `messageArgs` to `color-named` ([#8663](stylelint/stylelint#8663)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `messageArgs` to `declaration-property-value-keyword-no-deprecated` ([#8654](stylelint/stylelint#8654)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `no-descending-specificity` report message includes line number of the anchoring selector ([#8666](stylelint/stylelint#8666)) ([@immitsu](https://github.com/immitsu)). - Fixed: `at-rule-no-deprecated` false positives for `@apply` ([#8630](stylelint/stylelint#8630)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `lightness-notation` crash with `"number"` option and single-digit percentage ([#8661](stylelint/stylelint#8661)) ([@ybiquitous](https://github.com/ybiquitous)). ## [v16.21.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16211---2025-07-03) It fixes 3 bugs. - Fixed: unexpected change of syntax in computed `EditInfo` ([#8638](stylelint/stylelint#8638)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `function-linear-gradient-no-nonstandard-direction` false positives for CSS variables' names containing a direction substring ([#8643](stylelint/stylelint#8643)) ([@Solomon-mithra](https://github.com/Solomon-mithra)). - Fixed: `media-feature-range-notation` autofix for exact values ([#8651](stylelint/stylelint#8651)) ([@romainmenke](https://github.com/romainmenke)). ## [v16.21.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16210---2025-06-19) It rounds out the `message` secondary option and marks it as stable, adds 1 new option to a rule, and fixes 4 bugs. - Added: non-experimental support for functional `message` secondary option ([#8595](stylelint/stylelint#8595)) ([@ybiquitous](https://github.com/ybiquitous)). - Added: `ignore: ["after-custom-property"]` to `custom-property-empty-line-before` ([#8627](stylelint/stylelint#8627)) ([@imkesin](https://github.com/imkesin)). - Fixed: `cache` configuration property not being respected ([#8599](stylelint/stylelint#8599)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `fastest-levenshtein` import when bundling ([#8621](stylelint/stylelint#8621)) ([@onigoetz](https://github.com/onigoetz)). - Fixed: `named-grid-areas-no-invalid` false positives for interpolated grid-template-areas in CSS-in-JS ([#8606](stylelint/stylelint#8606)) ([@shahana308](https://github.com/shahana308)). - Fixed: `selector-pseudo-*-no-unknown` false positives for the missing form control styling selectors ([#8623](stylelint/stylelint#8623)) ([@tyrann0us](https://github.com/tyrann0us)).

@sw1tch3roo

| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.20.0 | 16.23.1 | ## [v16.23.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16231---2025-08-07) It fixes 7 bugs. - Fixed: `no-invalid-position-declaration` false positives for embedded styles ([#8701](stylelint/stylelint#8701)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Fixed: `property-no-deprecated` erroneously autofixing `clip` ([#8699](stylelint/stylelint#8699)) ([@immitsu](https://github.com/immitsu)). - Fixed: `property-no-deprecated` false positives for `-webkit-box-orient: vertical;` ([#8699](stylelint/stylelint#8699)) ([@immitsu](https://github.com/immitsu)). - Fixed: `selector-pseudo-*-no-unknown` false positives for some meter pseudo classes/elements ([#8708](stylelint/stylelint#8708)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-class-no-unknown` false positives for `:unchecked` ([#8705](stylelint/stylelint#8705)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-pseudo-element-no-unknown` false positives for `::search-text` ([#8707](stylelint/stylelint#8707)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `selector-type-no-unknown` false positives for `selectedcontent` ([#8716](stylelint/stylelint#8716)) ([@Mouvedia](https://github.com/Mouvedia)). ## [v16.23.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16230---2025-07-29) It adds 5 new rules, 1 option to a rule and fixes 3 bugs. We've turned on the new rules in our [standard config](https://www.npmjs.com/package/stylelint-config-standard). - Added: `block-no-redundant-nested-style-rules` rule ([#8684](stylelint/stylelint#8684)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `media-type-no-deprecated` rule ([#8668](stylelint/stylelint#8668)) ([@immitsu](https://github.com/immitsu)). - Added: `nesting-selector-no-missing-scoping-root` rule ([#8674](stylelint/stylelint#8674)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `no-invalid-position-declaration` rule ([#8669](stylelint/stylelint#8669)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Added: `property-no-deprecated` rule ([#8682](stylelint/stylelint#8682)) ([@immitsu](https://github.com/immitsu)). - Added: `except: ["exact-value"]` to `media-feature-range-notation` ([#8675](stylelint/stylelint#8675)) ([@immitsu](https://github.com/immitsu)). - Fixed: `declaration-block-no-duplicate-properties` false negatives for named colors with `ignore: ['consecutive-duplicates-with-different-syntaxes']` ([#8665](stylelint/stylelint#8665)) ([@sw1tch3roo](https://github.com/sw1tch3roo)). - Fixed: `function-no-unknown` false positives ([#8677](stylelint/stylelint#8677)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `no-irregular-whitespace` false positives for strings ([#8667](stylelint/stylelint#8667)) ([@immitsu](https://github.com/immitsu)). ## [v16.22.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16220---2025-07-18) It adds 3 rule features and fixes 2 bugs. - Added: `messageArgs` to `color-named` ([#8663](stylelint/stylelint#8663)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `messageArgs` to `declaration-property-value-keyword-no-deprecated` ([#8654](stylelint/stylelint#8654)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `no-descending-specificity` report message includes line number of the anchoring selector ([#8666](stylelint/stylelint#8666)) ([@immitsu](https://github.com/immitsu)). - Fixed: `at-rule-no-deprecated` false positives for `@apply` ([#8630](stylelint/stylelint#8630)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `lightness-notation` crash with `"number"` option and single-digit percentage ([#8661](stylelint/stylelint#8661)) ([@ybiquitous](https://github.com/ybiquitous)). ## [v16.21.1](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16211---2025-07-03) It fixes 3 bugs. - Fixed: unexpected change of syntax in computed `EditInfo` ([#8638](stylelint/stylelint#8638)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `function-linear-gradient-no-nonstandard-direction` false positives for CSS variables' names containing a direction substring ([#8643](stylelint/stylelint#8643)) ([@Solomon-mithra](https://github.com/Solomon-mithra)). - Fixed: `media-feature-range-notation` autofix for exact values ([#8651](stylelint/stylelint#8651)) ([@romainmenke](https://github.com/romainmenke)). ## [v16.21.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16210---2025-06-19) It rounds out the `message` secondary option and marks it as stable, adds 1 new option to a rule, and fixes 4 bugs. - Added: non-experimental support for functional `message` secondary option ([#8595](stylelint/stylelint#8595)) ([@ybiquitous](https://github.com/ybiquitous)). - Added: `ignore: ["after-custom-property"]` to `custom-property-empty-line-before` ([#8627](stylelint/stylelint#8627)) ([@imkesin](https://github.com/imkesin)). - Fixed: `cache` configuration property not being respected ([#8599](stylelint/stylelint#8599)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: `fastest-levenshtein` import when bundling ([#8621](stylelint/stylelint#8621)) ([@onigoetz](https://github.com/onigoetz)). - Fixed: `named-grid-areas-no-invalid` false positives for interpolated grid-template-areas in CSS-in-JS ([#8606](stylelint/stylelint#8606)) ([@shahana308](https://github.com/shahana308)). - Fixed: `selector-pseudo-*-no-unknown` false positives for the missing form control styling selectors ([#8623](stylelint/stylelint#8623)) ([@tyrann0us](https://github.com/tyrann0us)).

Created a new rule: "no-invalid-position-declaration"

3f00ad7

Merge branch 'main' into feature/no-invalid-position-declaration

17a8f17

jeddy3 requested changes Jul 14, 2025

View reviewed changes

jeddy3 changed the title ~~Added a new rule: "no-invalid-position-declaration"~~ Add no-invalid-position-declaration Jul 14, 2025

Create proud-singers-punch.md

2c819fc

jeddy3 mentioned this pull request Jul 14, 2025

Add media-type-no-deprecated rule #8668

Merged

sw1tch3roo and others added 2 commits July 14, 2025 21:39

Apply suggestions from code review

df1cdcb

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

changes after review: fix no-invalid-position-declaration rule to cat…

b4ec245

…ch declarations in at-rules that only accept <rule-list>, apply suggestions from code review

sw1tch3roo requested a review from jeddy3 July 14, 2025 19:05

ybiquitous reviewed Jul 15, 2025

View reviewed changes

lib/rules/no-invalid-position-declaration/__tests__/index.mjs Show resolved Hide resolved

sw1tch3roo and others added 2 commits July 15, 2025 12:07

Merge branch 'main' into feature/no-invalid-position-declaration

992908b

Add endLine and endColumn to no-invalid-position-declaration reject t…

16a805c

…est cases

sw1tch3roo requested a review from ybiquitous July 15, 2025 09:25

jeddy3 requested changes Jul 15, 2025

View reviewed changes

jeddy3 mentioned this pull request Jul 15, 2025

Document conventions for writing tests #8672

Merged

Apply suggestions from code review

69b3aeb

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

sw1tch3roo requested a review from jeddy3 July 15, 2025 15:02

sw1tch3roo force-pushed the feature/no-invalid-position-declaration branch from 7b0206f to da2c1ba Compare July 15, 2025 15:07

Add nested at-rule support and refactor 'no-invalid-position-declarat…

4fd9d2a

…ion' rule

sw1tch3roo force-pushed the feature/no-invalid-position-declaration branch from da2c1ba to 4fd9d2a Compare July 15, 2025 16:50

jeddy3 requested changes Jul 15, 2025

View reviewed changes

Apply suggestions from code review

d13f890

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

sw1tch3roo and others added 2 commits July 15, 2025 20:32

Merge branch 'main' into feature/no-invalid-position-declaration

4f436c5

add new case to accepted tests, move keywords import to the first line

4858875

sw1tch3roo requested a review from jeddy3 July 15, 2025 18:05

jeddy3 reviewed Jul 16, 2025

View reviewed changes

lib/rules/no-invalid-position-declaration/index.mjs Outdated Show resolved Hide resolved

Update lib/rules/no-invalid-position-declaration/index.mjs

38bb265

jeddy3 requested changes Jul 16, 2025

View reviewed changes

lib/rules/no-invalid-position-declaration/index.mjs Show resolved Hide resolved

sw1tch3roo and others added 2 commits July 16, 2025 10:36

Update lib/rules/no-invalid-position-declaration/index.mjs

5702c5b

Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

add isStandardSyntaxDeclaration import, sort imports

4921715

sw1tch3roo requested a review from jeddy3 July 16, 2025 08:00

jeddy3 approved these changes Jul 16, 2025

View reviewed changes

Mouvedia reviewed Jul 17, 2025

View reviewed changes

lib/rules/no-invalid-position-declaration/README.md Show resolved Hide resolved

Mouvedia reviewed Jul 17, 2025

View reviewed changes

lib/rules/no-invalid-position-declaration/index.mjs Show resolved Hide resolved

Mouvedia reviewed Jul 17, 2025

View reviewed changes

lib/rules/no-invalid-position-declaration/__tests__/index.mjs Show resolved Hide resolved

Mouvedia mentioned this pull request Jul 17, 2025

Add missing rules and options to stylelintrc.json stylelint/stylelint-demo#448

Open

17 tasks

sw1tch3roo added 2 commits July 18, 2025 16:17

Merge branch 'main' into feature/no-invalid-position-declaration

56eef91

Merge branch 'main' into feature/no-invalid-position-declaration

d609a07

ybiquitous approved these changes Jul 25, 2025

View reviewed changes

lib/rules/no-invalid-position-declaration/index.mjs Show resolved Hide resolved

use typeGuards utils

5adfc6b

sw1tch3roo force-pushed the feature/no-invalid-position-declaration branch from e0b8122 to 5adfc6b Compare July 25, 2025 10:30

Merge branch 'main' into feature/no-invalid-position-declaration

81e383b

jeddy3 merged commit 87c8ed5 into stylelint:main Jul 25, 2025
16 of 17 checks passed

Uh oh!

Add no-invalid-position-declaration #8669

Add no-invalid-position-declaration #8669

Uh oh!

Conversation

sw1tch3roo commented Jul 13, 2025

Uh oh!

changeset-bot bot commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jeddy3 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sw1tch3roo commented Jul 15, 2025

Uh oh!

Uh oh!

jeddy3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sw1tch3roo commented Jul 16, 2025

Uh oh!

jeddy3 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sw1tch3roo commented Jul 17, 2025

Uh oh!

Mouvedia commented Jul 17, 2025

Uh oh!

sw1tch3roo commented Jul 23, 2025

Uh oh!

jeddy3 commented Jul 24, 2025

Uh oh!

ybiquitous left a comment

Add `no-invalid-position-declaration` #8669

Add `no-invalid-position-declaration` #8669

changeset-bot bot commented Jul 13, 2025 •

edited

Loading

github-actions bot commented Jul 15, 2025 •

edited

Loading

jeddy3 left a comment •

edited

Loading

jeddy3 left a comment •

edited

Loading