Skip to content

Fix at-rule-no-deprecated false positives for @apply #8630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mouvedia merged 5 commits into from
Jul 8, 2025
Merged

Fix at-rule-no-deprecated false positives for @apply #8630

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
695c2de
Fix `at-rule-no-deprecated` false positives for `@apply`
Mouvedia Jun 20, 2025
d23b4c1
code review 1
Mouvedia Jun 24, 2025
f08f592
add test for `at-rule-descriptor-value-no-unknown`
Mouvedia Jun 28, 2025
f07cb3d
add test for `at-rule-descriptor-no-unknown`
Mouvedia Jun 28, 2025
f216515
add TODO comments
Mouvedia Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test for at-rule-descriptor-no-unknown
  • Loading branch information
@Mouvedia
Mouvedia committed Jun 28, 2025
commit f07cb3d018902f77d3e27379192dbda68d3ed50d
49 changes: 49 additions & 0 deletions lib/rules/at-rule-descriptor-no-unknown/__tests__/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import rule from '../index.mjs';
import { stripIndent } from 'common-tags';

const { messages, ruleName } = rule;

testRule({
Expand Down Expand Up @@ -153,5 +155,52 @@ testRule({
},
],
},
{
code: stripIndent`
@mixin --qux-baz(@contents) {
@supports (overflow-anchor: auto) {
@contents;
}
}

body {
@apply --qux-baz {
@font-face {
foo: normal;
}
}
}
`,
message: messages.rejected('@font-face', 'foo'),
line: 10,
column: 5,
endLine: 10,
endColumn: 8,
description: 'without indirection',
},
{
code: stripIndent`
@mixin --qux-baz(@contents) {
@supports (overflow-anchor: auto) {
@font-face {
@contents;
}
}
}

body {
@apply --qux-baz {
foo: normal;
}
}
Comment on lines +183 to +195
Copy link
Member Author

@Mouvedia Mouvedia Jun 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on a real-world use case

`,
message: messages.rejected('@font-face', 'foo'),
line: 11,
column: 3,
endLine: 11,
endColumn: 6,
description: 'with indirection',
skip: true,
},
],
});