Skip to content

Add GitHub action to change the label and add a warning comment on issues older than a month #7486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ybiquitous merged 3 commits into from
Jan 22, 2024
Merged

Add GitHub action to change the label and add a warning comment on issues older than a month #7486

ybiquitous merged 3 commits into from
Jan 22, 2024

Conversation

@ybiquitous
Copy link
Member

@ybiquitous ybiquitous commented Jan 21, 2024 •
edited
Loading

Which issue, if any, is this issue related to?

Closes #7459

Is there anything in the PR that needs further explanation?

How about labeling with stale to avoid duplicate comments? Is this irregular label acceptable only for this action?
This action will comment on older issues than one month, and will replace the "ready to implement" label with "ask to implement". See #7486 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8b5fa51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Mouvedia
Mouvedia reviewed Jan 21, 2024
View reviewed changes
@Mouvedia
Copy link
Member

Mouvedia commented Jan 21, 2024 •
edited
Loading

How about labeling with stale to avoid duplicate comments?

It may help with issues that had many comments after the bot warning comment.
A newcomer might only read the latest comments and miss it.
Hence the label may serve as a second fail-safe if you consider ask to implement not explicit enough.

jeddy3
jeddy3 requested changes Jan 21, 2024
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this!

I've made some suggestions for the labels we use.

@jeddy3 jeddy3 changed the title Add GitHub action to add a warning comment on issues older than a month Add GitHub action to change the label and add a warning comment on issues older than a month Jan 21, 2024
@jeddy3 jeddy3 mentioned this pull request Jan 21, 2024
Closed
ybiquitous and others added 2 commits January 22, 2024 09:02
@ybiquitous @jeddy3
Update issue comment
b01d660 
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@ybiquitous
Replace "ready to implement" with "ask to implement" label
8b5fa51
@ybiquitous ybiquitous requested a review from jeddy3 January 22, 2024 00:18
jeddy3
jeddy3 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@ybiquitous
Copy link
Member Author

ybiquitous commented Jan 22, 2024

Thanks for the review. Let's try it!

If it works, I'll open a pull request to update the labels in the stylelint/.github repository.

@ybiquitous ybiquitous merged commit 0073ab6 into main Jan 22, 2024
@ybiquitous ybiquitous deleted the issue-7459 branch January 22, 2024 10:14
@ybiquitous
Copy link
Member Author

ybiquitous commented Jan 22, 2024

Oops, it failed. I'll open a PR to fix it soon.
https://github.com/stylelint/stylelint/actions/runs/7609612527/job/20721207993

@ybiquitous ybiquitous mentioned this pull request Jan 22, 2024
Merged
@ybiquitous
Copy link
Member Author

ybiquitous commented Jan 22, 2024

@Mouvedia Thanks for the advice quickly. But I believe the 3rd-party action is unnecessary. See #7491, which I opened now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mouvedia Mouvedia Mouvedia left review comments

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use a bot to add a warning comment on issues older than a month

4 participants

@ybiquitous @Mouvedia @jeddy3